Page MenuHomeFreeBSD

stand: efi create eficom console device.
ClosedPublic

Authored by imp on May 5 2023, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 5, 5:01 PM
Unknown Object (File)
Tue, Jan 14, 6:36 PM
Unknown Object (File)
Sat, Jan 11, 2:54 AM
Unknown Object (File)
Dec 5 2024, 8:18 PM
Unknown Object (File)
Dec 2 2024, 7:41 AM
Unknown Object (File)
Nov 17 2024, 10:23 AM
Unknown Object (File)
Nov 16 2024, 5:50 PM
Unknown Object (File)
Nov 16 2024, 6:41 AM

Details

Summary

Fix the 'renaming kludge' that we absolutely cannot do going forward
(it's cost us days of engineering time).

console=comconsole talks to the hardware directly. This is available
only on amd64. It is not available anywhere else (and so requires
changes for people doing comconsole on aarch64)

console=eficom talks to the console via EFI protocols. It's available
on amd64, aarch64 and riscv64. It's the first port that we find, though
it can be overriden by efi_com_port (which should be set to the UID of
the serial port, not the I/O port, despite the name). devinfo -v
will give the UID to uartX mapping.

This is an incompatible change for HYPER-V on amd64. It only works with
eficom console, so you'll need to change your configuration in
loader.conf. No compatibility hack will ever be provided for this (since
it requires renamig, which the loader cannot reliably do).

It's also an incompatible change for aarch64. comconsole will need to
change to eficom. There might be a comconsole "shim" for this.

All the interlock to keep only eficom and comconsole from both attaching
have been removed.

RelNotes: Yes
Sponsored by: Netflix

Test Plan

Note: Docs should be updated, but there are currently no docs for EFI serial.
I'll give it a try before I commit, but I don't have the patience to do it today.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51348
Build 48239: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 5 2023, 9:39 PM

I'll chime in to say that the bug being fixed here has cost me days, and days of time over the last few weeks dealing with the loader crashing 100% of the time on recent AMD EPYC and Intel Xeon boards from Tyan.

imp added reviewers: emaste, kevans, tsoome.
This revision was not accepted when it landed; it landed in state Needs Review.May 11 2023, 8:07 PM
This revision was automatically updated to reflect the committed changes.