vmm: don't free unallocated memory
ClosedPublic
Actions

Authored by corvink on May 5 2023, 6:44 AM.

Tags

None

Referenced Files

	F115727391: D39974.diff
	Sun, Apr 27, 6:43 PM

	Unknown Object (File)
	Sat, Apr 19, 5:03 PM

	Unknown Object (File)
	Fri, Apr 18, 10:57 PM

	Unknown Object (File)
	Fri, Apr 18, 7:03 PM

	Unknown Object (File)
	Fri, Apr 18, 6:28 PM

	Unknown Object (File)
	Fri, Apr 18, 6:21 PM

	Unknown Object (File)
	Fri, Apr 18, 4:53 PM

	Unknown Object (File)
	Thu, Apr 17, 12:05 PM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rGbe14baa34b82: vmm: don't free unallocated memory
rGb10e100d1696: vmm: don't free unallocated memory

Summary

If vmx or svm is disabled in BIOS or the device isn't supported by vmm,
modinit won't allocate these state save areas. As kmem_free panics when
passing a NULL pointer to it, loading the vmm kernel module causes a
panic too.

PR: 271251

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51337
Build 48228: arc lint + arc unit

Event Timeline

corvink created this revision.May 5 2023, 6:44 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 5 2023, 6:44 AM

corvink requested review of this revision.May 5 2023, 6:44 AM

Harbormaster completed remote builds in B51337: Diff 121555.May 5 2023, 6:44 AM

Thanks!

This revision is now accepted and ready to land.May 5 2023, 1:15 PM

Closed by commit rGb10e100d1696: vmm: don't free unallocated memory (authored by corvink). · Explain WhyMay 5 2023, 1:34 PM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGb10e100d1696: vmm: don't free unallocated memory.

markj added a commit: rGbe14baa34b82: vmm: don't free unallocated memory.May 11 2023, 1:33 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

amd/

svm.c

5 lines

intel/

vmx.c

4 lines

Diff 121555

View Options

sys/amd64/vmm/amd/svm.c