authpf: do not sprintf to a null pointer
ClosedPublic
Actions

Authored by emaste on May 3 2023, 1:31 PM.

Details

Reviewers

Commits

rGc6062b358862: authpf: do not sprintf to a null pointer
rG81f964e2ffb7: authpf: do not sprintf to a null pointer

Summary

The fgetln loop will terminate with buf = NULL at EOF.

Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.May 3 2023, 1:31 PM

emaste created this revision.

/tmp/cirrus-ci-build/contrib/pf/authpf/authpf.c:570:17: warning: argument 1 null where non-null expected [-Wnonnull]
  570 |                 sprintf(buf, "%s", "\n\nSorry, you are not allowed to use this facility!\n");
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/cirrus-ci-build/sys/sys/nv.h:44,
                 from /tmp/cirrus-ci-build/sys/net/pfvar.h:44,
                 from /tmp/cirrus-ci-build/contrib/pf/authpf/authpf.c:31:
/usr/obj/tmp/cirrus-ci-build/amd64.amd64/tmp/usr/include/stdio.h:286:10: note: in a call to function 'sprintf' declared 'nonnull'
  286 | int      sprintf(char * __restrict, const char * __restrict, ...);
      |          ^~~~~~~

kp accepted this revision.May 3 2023, 1:34 PM

This revision is now accepted and ready to land.May 3 2023, 1:34 PM

emaste mentioned this in D37627: Disable errors for -Wnonnull for the kernel for GCC 12..May 3 2023, 2:01 PM

Closed by commit rG81f964e2ffb7: authpf: do not sprintf to a null pointer (authored by emaste). · Explain WhyMay 3 2023, 2:04 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG81f964e2ffb7: authpf: do not sprintf to a null pointer.

Herald added a subscriber: imp. · View Herald TranscriptMay 3 2023, 2:04 PM

emaste added a commit: rGc6062b358862: authpf: do not sprintf to a null pointer.May 6 2023, 12:30 AM

jhb added a subscriber: jhb.May 8 2023, 5:55 PM

jhb added inline comments.