Differential D39932

ifconfig: split argument parsing and actual execution.
ClosedPublic
Actions

Authored by melifaro on May 2 2023, 9:38 AM.

Details

Reviewers

Commits

rG982cd5ae8ef6: ifconfig: split argument parsing and actual execution logic

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51305
Build 48196: arc lint + arc unit

Event Timeline

melifaro created this revision.May 2 2023, 9:38 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 2 2023, 9:38 AM

melifaro requested review of this revision.May 2 2023, 9:38 AM

Harbormaster completed remote builds in B51305: Diff 121373.May 2 2023, 9:38 AM

Are you planning on doing more cleanup work in ifconfig?

This is clearly a step in the right direction, but there are a lot more steps to take in ifconfig.

This revision is now accepted and ready to land.May 3 2023, 7:19 AM

swills added a subscriber: swills.May 7 2023, 12:31 PM

Closed by commit rG982cd5ae8ef6: ifconfig: split argument parsing and actual execution logic (authored by melifaro). · Explain WhyMay 10 2023, 10:42 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG982cd5ae8ef6: ifconfig: split argument parsing and actual execution logic.

In D39932#909217, @kp wrote:

Are you planning on doing more cleanup work in ifconfig?

To some extent :-) This change is first in the series to switch ifconfig to Netlink.

This is clearly a step in the right direction, but there are a lot more steps to take in ifconfig.

After looking into the code - yeah there certainly are :-)

melifaro added a child revision: D40033: ifconfig: split printing functions into smaller per-type chunks..May 10 2023, 11:21 AM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifconfig.h

17 lines

ifconfig.c

136 lines

Diff 121373

View Options

sbin/ifconfig/ifconfig.h