Page MenuHomeFreeBSD
Differential D39860

tcp_rack: allow the module to be loaded without TCP_BLACKBOX
ClosedPublic
Actions

Authored by tuexen on Apr 27 2023, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 24, 4:03 AM
Unknown Object (File)
Fri, Oct 18, 8:45 AM
Unknown Object (File)
Oct 2 2024, 4:02 AM
Unknown Object (File)
Sep 26 2024, 1:30 PM
Unknown Object (File)
Sep 18 2024, 9:57 PM
Unknown Object (File)
Sep 16 2024, 11:34 PM
Unknown Object (File)
Sep 8 2024, 3:38 PM
Unknown Object (File)
Sep 8 2024, 2:54 PM
View All 33 Files
Subscribers
gbe
glebius
imp
melifaro
netchild

Details

Reviewers
rrs
rscheff
cc
Group Reviewers
transport
Commits
rG113f56ba4930: tcp_rack: allow the module to be loaded without TCP_BLACKBOX
Summary

This fixes the issue reported in PR 271091.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Apr 27 2023, 9:15 PM
Herald added a reviewer: transport. · View Herald TranscriptApr 27 2023, 9:15 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Apr 27 2023, 9:15 PM
netchild added a subscriber: netchild.Apr 28 2023, 6:17 AM

Should the man-page tcp_rack(4) be changed at the same time to mention TCP_BLACKBOX as an optional dependency (and what feature it unlocks in rack)?

gbe added a subscriber: gbe.Apr 28 2023, 7:04 AM
tuexen added a comment.Apr 28 2023, 10:55 AM
In D39860#907451, @netchild wrote:

Should the man-page tcp_rack(4) be changed at the same time to mention TCP_BLACKBOX as an optional dependency (and what feature it unlocks in rack)?

I think the way to go would be to add a man page for TCP Black Box Logging (BBLog). It allows logging events and packets for the FreeBSD base stack, the RACK and the BBR stack. Logging is most detailed for the RACK stack. Please note that TCP_BLACKBOX is enabled by default.

Adding a BBLog man-page has no relation to fixing the build problem.

cc accepted this revision as: cc.Apr 28 2023, 11:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 6 2023, 9:05 AM
Closed by commit rG113f56ba4930: tcp_rack: allow the module to be loaded without TCP_BLACKBOX (authored by tuexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rG113f56ba4930: tcp_rack: allow the module to be loaded without TCP_BLACKBOX.

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 121166

View Options

sys/netinet/tcp_log_buf.h

Loading...