Improve error message for exports lines

[walker.aj325_gmail.com]

Summary

Currently mountd will print error message "symbolic link in export path or statfs failed" in case some path component in an exports line fails validation. This revision improves the error message by giving more information about the precise error as well as the path component that caused the issue.

[rmacklem]

Made a couple of inline suggestions, but the code does
look correct to me.
I assume you do not have src commit bit, given your login name?

If that is the case..mav@ are you going to commit this or should I?
(I think it can qualify as a bug fix and go into main during code slush.
Do you guys agree?)

usr.sbin/mountd/mountd.c

1639

Minor nit. Although not needed for correctness,
I think setting err_msg = NULL here might be useful
as an extra safety belt and for readability.
(I'd only initialize it to NULL
when declared if the compiler complains it "might not
be initialized".)

But I'll leave this change up to you.

3799

I'd update this comment to accurately note what this
function does. Then I would put an updated comment
on check_dirpath() as follows:
check_dirpath() now also does
statfs(), which is not a part of checking for a symbolic link,
so I'd say the comment for check_dirpath() should mention
that as well as checking for a symbolic link.

[rmacklem]

usr.sbin/mountd/mountd.c

3856

Since statfs() is really a separate operation from
checking for a symbolic link, you might want to move
the above code block into a separate function and call it
after check_dirpath(), similar to how the unpatched
code called check_dirpath() and then statfs().

Just a suggestion.

[walker.aj325_gmail.com]

Moved statfs check to different function. Updated comments. Initialized err_msg to NULL on each loop iteration.

[rmacklem]

Except for the minor nit that "ret" no longer
does anything and can be removed, it
looks fine to me now.

Can you commit it or do you want me to do so?
(If I do it, I'll put a submitted by on it.)
If I'm committing it, I'll delete "ret".

Thanks for the patch, rick

usr.sbin/mountd/mountd.c

3832–3833

You could get rid of "ret", since it no longer
does anything.

[walker.aj325_gmail.com]

After some discussion with Mav, I switched to initializing err_msg to NULL and resetting it after free() if we encounter an error. Removed now-unused variable.

[walker.aj325_gmail.com]

Thanks for the feedback Rick. I unfortunately don't have commit rights and someone else will have to do that for me.

[walker.aj325_gmail.com]

Fix undefined reference that crept in while applying suggested changes.

[rmacklem]

The "int ret = 1;" appears to still be in the patch.
I suspect that is just uploading the wrong version.
Trivial to fix during commit.

So mav@, do you want to commit it or shall I?
(Also, if you have any comments w.r.t. the current
version, please do so.)

[walker.aj325_gmail.com]

Remove unused variable

[rmacklem]

Looks fine to me. I'll wait to hear from mav@
w.r.t. which one of us will commit it.

Again, thanks for the patch, rick