Enable building tar for non-FreeBSD host

[sjg]

Summary

For DIRDEPS_BUILD we need Makefile.depend.options to
force libegacy to be built on older FreeBSD and non-FreeBSD hosts.

[jrtc27]

Out of interest do you know if macOS needs any changes to the config file? I could believe not given it's closer to the BSDs than Linux.

tools/build/Makefile

171

macOS has this; is there an issue with using FreeBSD's instead? Also how does this actually link? AFAICT libegacy won't have readpassphrase.c?

[sjg]

tools/build/Makefile

171

libbsd provides readpassphrase, which is presumably intended to be compatible, but using -I/usr/include/bsd opens a whole new can of worms.
So this is the simplest solution.

As for mac I expect it should "just work" but not sure if I can test.

[jrtc27]

tools/build/Makefile

171

Oh... it shouldn't be using libbsd, libegacy is supposed to contain everything needed when cross-building, rather than mixing in-tree things and whatever libbsd's doing.

[arichardson]

usr.bin/tar/Makefile

39 ↗

(On Diff #120879)

If I recall correctly I ran into some behaviour differences when using libbsd for the bootstrap tools, so I decided against using it. Since we already have -legacy we can hopefully just add the readpassphrase source to that?

[sjg]

tools/build/Makefile

171

libegacy does not currently provide readpassphrase
so that should be added?
AFAIK that's the only thing missing

usr.bin/tar/Makefile

39 ↗

(On Diff #120879)

That would be fine by me

[jrtc27]

tools/build/Makefile

171

Yes, we've added things to libegacy as needed for cross-building, it basically functions as a libbsd for cross-building

[sjg]

Add readpassphrase to libegacy to avoid libbsd

[jrtc27]

tools/build/Makefile

227

Just put this in tools/build/includes.h and add that to INCS?

[sjg]

Get _PATH_TTY from paths.h

[sjg]

tools/build/Makefile

227

If/when something outside of libegacy needs it
But I could add an includes.h if preferred

[sjg]

Add includes.h to include/linux

[sjg]

tools/build/Makefile

227

Actually -I${.CURDIR} doesn't work we get tools/build/fcntl.h which doesn't work
I put it in cross-build/include/linux

[jrtc27]

usr.bin/tar/Makefile

38 ↗

(On Diff #120883)

This breaks building the tests for world on !FreeBSD

[jrtc27]

usr.bin/tar/Makefile

38 ↗

(On Diff #120883)

And whatever the right fix for this is should likely be done elsewhere by whacking MK_TESTS globally?

[sjg]

Do not block target tests of tar when building on non-FreeBSD

[sjg]

Disable MK_TESTS in src.opts.mk when appropriate

[imp]

share/mk/src.opts.mk

365

Ugggg... Please add TESTS to the BROKEN list instead.

[sjg]

Use BROKEN_OPTIONS for TESTS

[imp]

Looks good. Thanks for the ping.