Page MenuHomeFreeBSD
Differential D39742

bsdinstall avoid subdir depending on parent
ClosedPublic
Actions

Authored by sjg on Apr 21 2023, 3:57 AM.
Tags
None
Referenced Files
F109758772: D39742.id120786.diff
Sun, Feb 9, 4:25 AM
F109758734: D39742.id120788.diff
Sun, Feb 9, 4:24 AM
Unknown Object (File)
Sat, Feb 8, 9:41 PM
Unknown Object (File)
Sat, Feb 8, 4:59 AM
Unknown Object (File)
Tue, Feb 4, 8:06 PM
Unknown Object (File)
Tue, Feb 4, 4:46 PM
Unknown Object (File)
Sun, Jan 12, 7:51 AM
Unknown Object (File)
Dec 9 2024, 2:11 AM
View All 45 Files
Subscribers
None

Details

Reviewers
stevek
imp
bdrewery
obrien
Commits
rG0c3627f44d49: bsdinstall avoid subdir depending on parent
Summary

When not doing tree walks, it is bad for sub-dirs to depend on
parents. Move the generation of opt_osname.h to distextract
and have others that need that depend on it.

In usr.sbin/bsdinstall use SUBDIR_DEPEND_ so tree walking still works.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51087
Build 47978: arc lint + arc unit

Event Timeline

sjg requested review of this revision.Apr 21 2023, 3:57 AM
sjg created this revision.
Harbormaster completed remote builds in B51087: Diff 120786.Apr 21 2023, 3:57 AM
obrien added a reviewer: obrien.Apr 21 2023, 4:01 AM
obrien added a subscriber: obrien.
obrien removed a subscriber: obrien.

Looks good.

obrien accepted this revision.Apr 21 2023, 4:03 AM
This revision is now accepted and ready to land.Apr 21 2023, 4:03 AM
Closed by commit rG0c3627f44d49: bsdinstall avoid subdir depending on parent (authored by sjg). · Explain WhyApr 21 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rG0c3627f44d49: bsdinstall avoid subdir depending on parent.

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
9 lines
distextract/
11 lines
distfetch/
2 lines
partedit/
2 lines

Diff 120786

View Options

usr.sbin/bsdinstall/Makefile

Loading...
View Options

usr.sbin/bsdinstall/distextract/Makefile

Loading...
View Options

usr.sbin/bsdinstall/distfetch/Makefile

Loading...
View Options

usr.sbin/bsdinstall/partedit/Makefile

Loading...