LinuxKPI: fix READ_ONCE() -Wcast-equal warnings
ClosedPublic
Actions

Authored by bz on Apr 19 2023, 9:48 PM.

Tags

None

Referenced Files

	F101998918: D39706.diff
	Wed, Nov 6, 9:21 AM

	Unknown Object (File)
	Sun, Nov 3, 4:26 PM

	Unknown Object (File)
	Fri, Oct 18, 4:27 AM

	Unknown Object (File)
	Thu, Oct 17, 3:32 AM

	Unknown Object (File)
	Mon, Oct 7, 9:08 PM

	Unknown Object (File)
	Oct 2 2024, 9:07 PM

	Unknown Object (File)
	Oct 2 2024, 3:18 AM

	Unknown Object (File)
	Sep 15 2024, 5:12 PM

Subscribers

Details

Reviewers

jhb
emaste
• hselasky

Commits

rG38f969d41c54: LinuxKPI: fix READ_ONCE() -Wcast-equal warnings
rG74e908b3c63b: LinuxKPI: fix READ_ONCE() -Wcast-equal warnings

Summary

Rather than using ACCESS_ONCE() in READ_ONCE() add a missing cast
to const in order to satisfy -Wcast-equal by gcc.
Sadly we cannot do the same to WRITE_ONCE() which still is very
noisy.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Apr 19 2023, 9:48 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 19 2023, 9:48 PM

bz requested review of this revision.Apr 19 2023, 9:48 PM

Harbormaster completed remote builds in B51043: Diff 120694.Apr 19 2023, 9:48 PM

Looks good!

This revision is now accepted and ready to land.Apr 19 2023, 9:52 PM

Closed by commit rG74e908b3c63b: LinuxKPI: fix READ_ONCE() -Wcast-equal warnings (authored by bz). · Explain WhyApr 20 2023, 11:52 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG74e908b3c63b: LinuxKPI: fix READ_ONCE() -Wcast-equal warnings.

bz added a commit: rG38f969d41c54: LinuxKPI: fix READ_ONCE() -Wcast-equal warnings.Jun 26 2023, 12:09 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

compiler.h

2 lines

Diff 120716

View Options

sys/compat/linuxkpi/common/include/linux/compiler.h

LinuxKPI: fix READ_ONCE() -Wcast-equal warningsClosedPublicActions