Page MenuHomeFreeBSD
Differential D39673

iwlwifi: rtw88: rtw89: fix gcc warnings
ClosedPublic
Actions

Authored by bz on Apr 18 2023, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 24, 11:14 AM
Unknown Object (File)
Thu, Oct 24, 11:14 AM
Unknown Object (File)
Thu, Oct 24, 11:14 AM
Unknown Object (File)
Thu, Oct 24, 10:55 AM
Unknown Object (File)
Sun, Oct 20, 4:44 AM
Unknown Object (File)
Sun, Oct 20, 3:00 AM
Unknown Object (File)
Oct 5 2024, 5:39 AM
Unknown Object (File)
Oct 4 2024, 10:30 AM
View All 36 Files
Subscribers
imp

Details

Reviewers
jhb
emaste
Commits
rGda37ca4a9acb: iwlwifi: rtw88: rtw89: fix gcc warnings
rGf621b087c007: iwlwifi: rtw88: rtw89: fix gcc warnings
Summary

Fix -Wno-format and unused variables warnings with gcc by adopting
(to|the) FreeBSD-specific code.

Reported by: jhb
Sponsored by: The FreeBSD Foundation
MFC after: 3 days

(cherry picked from commit a7cd957c0847a4ffacc856e0e25f59d49fcf575d)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51018
Build 47909: arc lint + arc unit

Event Timeline

bz created this revision.Apr 18 2023, 8:45 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2023, 8:45 PM
bz requested review of this revision.Apr 18 2023, 8:45 PM
Harbormaster completed remote builds in B51018: Diff 120612.Apr 18 2023, 8:45 PM
jhb accepted this revision.Apr 18 2023, 9:58 PM
jhb added inline comments.
sys/contrib/dev/iwlwifi/iwl-debug.c
52

Ah, that's cute.

This revision is now accepted and ready to land.Apr 18 2023, 9:58 PM
bz marked an inline comment as done.Apr 18 2023, 10:52 PM
bz added inline comments.
sys/contrib/dev/iwlwifi/iwl-debug.c
52

Feels silly like cheating it but allows to keep the code around as such in case I'd implement more trace_iwlwifi_* bits.

Closed by commit rGf621b087c007: iwlwifi: rtw88: rtw89: fix gcc warnings (authored by bz). · Explain WhyApr 19 2023, 12:27 PM
This revision was automatically updated to reflect the committed changes.
bz marked an inline comment as done.
bz added a commit: rGf621b087c007: iwlwifi: rtw88: rtw89: fix gcc warnings.
bz added a commit: rGda37ca4a9acb: iwlwifi: rtw88: rtw89: fix gcc warnings.Jun 26 2023, 12:09 PM

Revision Contents
Changeset List

PathSize
sys/
contrib/
dev/
iwlwifi/
fw/
4 lines
6 lines
mvm/
4 lines
8 lines
4 lines
rtw88/
2 lines
rtw89/
2 lines
modules/
iwlwifi/
6 lines
rtw88/
3 lines

Diff 120612

View Options

sys/contrib/dev/iwlwifi/fw/dbg.h

Loading...
View Options

sys/contrib/dev/iwlwifi/iwl-debug.c

Loading...
View Options

sys/contrib/dev/iwlwifi/mvm/mac-ctxt.c

Loading...
View Options

sys/contrib/dev/iwlwifi/mvm/rx.c

Loading...
View Options

sys/contrib/dev/iwlwifi/mvm/rxmq.c

Loading...
View Options

sys/contrib/dev/rtw88/debug.c

Loading...
View Options

sys/contrib/dev/rtw89/debug.c

Loading...
View Options

sys/modules/iwlwifi/Makefile

Loading...
View Options

sys/modules/rtw88/Makefile

Loading...