Page MenuHomeFreeBSD

net80211: fix a typo in Rx MCS set for unequal modulation case
ClosedPublic

Authored by misha on Apr 14 2023, 7:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 27 2024, 2:04 AM
Unknown Object (File)
Sep 11 2024, 12:50 AM
Unknown Object (File)
Aug 21 2024, 3:03 AM
Unknown Object (File)
Aug 21 2024, 3:03 AM
Unknown Object (File)
Aug 21 2024, 3:03 AM
Unknown Object (File)
Aug 20 2024, 3:36 PM
Unknown Object (File)
Aug 12 2024, 10:06 PM
Unknown Object (File)
Jul 10 2024, 6:23 AM

Details

Summary

RX MCS set defines which MCSs are supported for RX, bits 0-31 are for equal modulation of the streams, bits 33-76 are for unequal case. Current code checks txstreams variable instead of rxstreams to set bits from 53 to 76 for 4 spatial streams case.

The modulations are defined in tables 19-38 and 19-41 of the IEEE Std 802.11-2020.

Spotted by bz in https://reviews.freebsd.org/D39476
Sponsored by: Serenity Cybersecurity, LLC

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 14 2023, 9:42 AM

One note for both changes: you mention tables of the standard but do not say which version of the standard. You may want to add IEEE Std 802.11-XXXX with XXXX being the year of the standard you are referring to?

In D39568#900712, @bz wrote:

One note for both changes: you mention tables of the standard but do not say which version of the standard. You may want to add IEEE Std 802.11-XXXX with XXXX being the year of the standard you are referring to?

Done, good point, thanks.