Paths

Table of Contentst

Differential D39549

bhyve: add E820 dump function
ClosedPublic
Actions

Authored by corvink on Apr 13 2023, 7:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 5:40 PM

	Unknown Object (File)
	Sun, Oct 20, 5:56 PM

	Unknown Object (File)
	Sep 19 2024, 3:30 PM

	Unknown Object (File)
	Sep 16 2024, 10:37 PM

	Unknown Object (File)
	Sep 16 2024, 4:10 PM

	Unknown Object (File)
	Sep 6 2024, 4:07 PM

	Unknown Object (File)
	Sep 6 2024, 12:45 AM

	Unknown Object (File)
	Sep 3 2024, 7:09 AM

View All 40 Files

Subscribers

Details

Reviewers

markj
jhb

Group Reviewers

Commits

rGf1b5ce0d1d75: bhyve: add E820 dump function
rGa8a8e9af574c: bhyve: add E820 dump function

Summary

For debugging purposes it is helpful to dump the E820 table.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50959
Build 47850: arc lint + arc unit

Event Timeline

corvink created this revision.Apr 13 2023, 7:09 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptApr 13 2023, 7:09 AM

corvink requested review of this revision.Apr 13 2023, 7:09 AM

Harbormaster completed remote builds in B50878: Diff 120247.Apr 13 2023, 7:09 AM

corvink added a child revision: D39550: bhyve: pass E820 table to guest.Apr 13 2023, 7:13 AM

corvink added a parent revision: D39547: bhyve: add allocation function to E820.

markj added inline comments.Apr 13 2023, 3:00 PM

usr.sbin/bhyve/e820.c
71	The returned strings are padded specifically to suit e820_dump_table(). Better would be to either inline this code in e820_dump_table(), or handling formatting in e820_dump_table() with "%10s" or so.
79	There's no need for carriage returns I think?
83

rebase
fix style issues

Harbormaster completed remote builds in B50959: Diff 120457.Apr 17 2023, 12:36 PM

corvink marked 3 inline comments as done.Apr 17 2023, 12:40 PM

corvink added inline comments.

usr.sbin/bhyve/e820.c
71	Looking at the `printf` it makes no sense to add padding at all.

markj accepted this revision as: markj.Apr 24 2023, 3:27 PM

This revision is now accepted and ready to land.Apr 24 2023, 3:27 PM

Closed by commit rGa8a8e9af574c: bhyve: add E820 dump function (authored by corvink). · Explain WhyApr 26 2023, 8:00 AM

This revision was automatically updated to reflect the committed changes.

corvink marked an inline comment as done.

corvink added a commit: rGa8a8e9af574c: bhyve: add E820 dump function.

corvink added a commit: rGf1b5ce0d1d75: bhyve: add E820 dump function.May 8 2023, 8:28 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

1 line

35 lines

Diff 120457

usr.sbin/bhyve/e820.h

Loading...

usr.sbin/bhyve/e820.c

Loading...