Paths

Table of Contentst

Differential D39516

tcp: make net.inet.tcp.functions_default vnet specific
ClosedPublic
Actions

Authored by tuexen on Apr 12 2023, 9:08 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 3, 10:56 AM

	Unknown Object (File)
	Wed, Dec 25, 6:17 AM

	Unknown Object (File)
	Dec 4 2024, 8:04 AM

	Unknown Object (File)
	Nov 20 2024, 1:40 AM

	Unknown Object (File)
	Oct 21 2024, 6:04 PM

	Unknown Object (File)
	Oct 17 2024, 3:59 PM

	Unknown Object (File)
	Oct 17 2024, 2:33 AM

	Unknown Object (File)
	Oct 15 2024, 5:22 AM

View All 79 Files

Subscribers

zarychtam_plan-b.pwste.edu.pl

Details

Reviewers

glebius
rrs
rscheff
cc

Group Reviewers

Commits

rGc687f21add77: tcp: make net.inet.tcp.functions_default vnet specific

Summary

Allow the sysctl-variable net.inet.tcp.functions_default to be vnet specific.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Apr 12 2023, 9:08 AM

Herald added a reviewer: transport. · View Herald TranscriptApr 12 2023, 9:08 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Apr 12 2023, 9:08 AM

zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Apr 12 2023, 9:42 AM

Thanks for taking care of the problem. Will it grow vnet memory requirements? Can the change be applied safely to stable/13? Are any plans to MFC when gets committed to HEAD ?

In D39516#899644, @zarychtam_plan-b.pwste.edu.pl wrote:

Thanks for taking care of the problem. Will it grow vnet memory requirements? Can the change be applied safely to stable/13? Are any plans to MFC when gets committed to HEAD ?

One pointer gets virtualized, so the memory requirements should be about the same. I think it can be MFCed to stable/13. Will test it and MFC, if it is actually works. Please note that this patch depends on D39514.

rrs accepted this revision.Apr 12 2023, 3:16 PM

This revision is now accepted and ready to land.Apr 12 2023, 3:16 PM

Looks good to me. If the ')' char can be removed as pointed out in my inline comment, that will be better!

sys/netinet/tcp_subr.c
1333	Shall remove this '(' character.

Closed by commit rGc687f21add77: tcp: make net.inet.tcp.functions_default vnet specific (authored by tuexen). · Explain WhyApr 12 2023, 4:07 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGc687f21add77: tcp: make net.inet.tcp.functions_default vnet specific.

tuexen added inline comments.Apr 12 2023, 4:14 PM

sys/netinet/tcp_subr.c
1333	Committed separately: https://cgit.FreeBSD.org/src/commit/?id=2ba2849c8275d4aeb2e4ca04aafaf89f1962910b

Revision Contents
Changeset List

Path

Size

sys/

netinet/

34 lines

Diff 120218

sys/netinet/tcp_subr.c

Loading...