Page MenuHomeFreeBSD
Differential D39515

bsd-user status report
ClosedPublic
Actions

Authored by imp on Apr 11 2023, 11:49 PM.
Tags
None
Referenced Files
F110016075: D39515.diff
Wed, Feb 12, 12:52 PM
Unknown Object (File)
Thu, Jan 30, 5:11 PM
Unknown Object (File)
Wed, Jan 15, 1:12 AM
Unknown Object (File)
Jan 9 2025, 12:04 AM
Unknown Object (File)
Jan 2 2025, 6:43 PM
Unknown Object (File)
Dec 17 2024, 1:16 PM
Unknown Object (File)
Dec 10 2024, 7:27 AM
Unknown Object (File)
Nov 28 2024, 12:19 PM
View All Files
Subscribers
None

Details

Reviewers
salvadore
Group Reviewers
status
Commits
R9:2e5c2a2d29f6: bsd-user status report

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50871
Build 47762: arc lint + arc unit

Event Timeline

imp created this revision.Apr 11 2023, 11:49 PM
Herald added a reviewer: salvadore. · View Herald TranscriptApr 11 2023, 11:49 PM
imp requested review of this revision.Apr 11 2023, 11:49 PM
Harbormaster completed remote builds in B50844: Diff 120171.Apr 11 2023, 11:49 PM
imp added a comment.Apr 11 2023, 11:49 PM

Hopefully this isn't too late....

salvadore added a reviewer: status.Apr 12 2023, 8:55 AM

It is not too late, do not worry. The status team will review it as soon as possible. Thanks for your report.

imp updated this revision to Diff 120220.Apr 12 2023, 4:36 PM

make things a bulleted list.

Harbormaster completed remote builds in B50867: Diff 120220.Apr 12 2023, 4:36 PM
salvadore added a comment.Apr 12 2023, 5:06 PM

Thanks Warner. There are a few things to fix and then it should be ready for commit.

website/content/en/status/report-2023-01-2023-03/bsd-user.adoc
2

I would have added a colon: bsd-user: Upstreaming and Status Report.
However, I also note that the title is redundant: it is clear that this is a status report, since it wil be published in the 2023Q1 status report.

9

Doug Rabson is mentioned multiple times in the report, I think it would be a good idea to add a contact for him as well.

11

It is not immediately clear who we is: the contact list includes only one person at the moment. I suggest to either add more contacts or use some workaround (e.g. use passive: two bits of code landed upstream).

Moreover, you wrote part of the report using the first person (I and we) and another part using the third person (Doug and Warner). I have no preference for a style over another, but it would be better to stay consistent with one style only.

13

Typo: s/Conact/Contact/.

20

Final period is missing.

31

Typo: s/big/bit/.

imp updated this revision to Diff 120236.Apr 13 2023, 1:55 AM

feedback from review

Harbormaster completed remote builds in B50871: Diff 120236.Apr 13 2023, 1:56 AM
imp added inline comments.Apr 13 2023, 1:56 AM
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc
9

Doug just did a few patches and isn't really expecting to do a lot more in the future, so I've not listed him as a contact.

salvadore accepted this revision.Apr 13 2023, 12:53 PM

Approved, but be careful on line 19: the period is still missing there.

website/content/en/status/report-2023-01-2023-03/bsd-user.adoc
19

Final period is still missing.

This revision is now accepted and ready to land.Apr 13 2023, 12:53 PM
salvadore added inline comments.Apr 15 2023, 9:20 AM
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc
4–6

May I ask you to also empty the last pair of brackets of each line so that I do not need to update https://reviews.freebsd.org/D39571? Thanks.

Closed by commit R9:2e5c2a2d29f6: bsd-user status report (authored by imp). · Explain WhyApr 15 2023, 3:31 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: R9:2e5c2a2d29f6: bsd-user status report.
imp added inline comments.Apr 15 2023, 3:33 PM
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc
4–6

Doh! I missed this the first time I looked at this page... I pushed in a second commit...
If there's anything else I've missed, please let me know so I can do it differently in the future.

Revision Contents
Changeset List

PathSize
website/
content/
en/
status/
report-2023-01-2023-03/
55 lines

Diff 120236

View Options

website/content/en/status/report-2023-01-2023-03/bsd-user.adoc

Loading...