Details
- Reviewers
salvadore - Group Reviewers
status - Commits
- R9:2e5c2a2d29f6: bsd-user status report
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
It is not too late, do not worry. The status team will review it as soon as possible. Thanks for your report.
Thanks Warner. There are a few things to fix and then it should be ready for commit.
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc | ||
---|---|---|
2 | I would have added a colon: bsd-user: Upstreaming and Status Report. | |
9 | Doug Rabson is mentioned multiple times in the report, I think it would be a good idea to add a contact for him as well. | |
11 | It is not immediately clear who we is: the contact list includes only one person at the moment. I suggest to either add more contacts or use some workaround (e.g. use passive: two bits of code landed upstream). Moreover, you wrote part of the report using the first person (I and we) and another part using the third person (Doug and Warner). I have no preference for a style over another, but it would be better to stay consistent with one style only. | |
13 | Typo: s/Conact/Contact/. | |
20 | Final period is missing. | |
31 | Typo: s/big/bit/. |
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc | ||
---|---|---|
9 | Doug just did a few patches and isn't really expecting to do a lot more in the future, so I've not listed him as a contact. |
Approved, but be careful on line 19: the period is still missing there.
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc | ||
---|---|---|
20 | Final period is still missing. |
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc | ||
---|---|---|
5–7 | May I ask you to also empty the last pair of brackets of each line so that I do not need to update https://reviews.freebsd.org/D39571? Thanks. |
website/content/en/status/report-2023-01-2023-03/bsd-user.adoc | ||
---|---|---|
5–7 | Doh! I missed this the first time I looked at this page... I pushed in a second commit... |