makefs(8): fix continuing lines' indentation
AbandonedPublic
Actions

Authored by christos on Apr 5 2023, 9:57 PM.

Details

Reviewers

markj
emaste

Summary

No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

christos created this revision.Apr 5 2023, 9:57 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 5 2023, 9:57 PM

christos requested review of this revision.Apr 5 2023, 9:57 PM

christos updated this revision to Diff 119926.

how does this interact with our efforts to reduce diffs with OpenBSD and NetBSD?

christos mentioned this in D39430: makefs(8): do not print comma after the last super-block.Apr 5 2023, 10:00 PM

christos added a child revision: D39430: makefs(8): do not print comma after the last super-block.

In D39443#897801, @imp wrote:

how does this interact with our efforts to reduce diffs with OpenBSD and NetBSD?

After a quick look at their code, it looks like they haven't fixed this either.

In D39443#897812, @christos wrote:

In D39443#897801, @imp wrote:

how does this interact with our efforts to reduce diffs with OpenBSD and NetBSD?

After a quick look at their code, it looks like they haven't fixed this either.

I think the point is that we'd rather not diverge from them more than necessary. For instance, this makes it harder to compare the different versions to find bug fixes. Sweeping style commits are generally discouraged for reasons like this.

christos abandoned this revision.Apr 6 2023, 11:30 AM