Page MenuHomeFreeBSD
Differential D39315

bhyve/fwcfg: add QEMU_FWCFG_INDEX_MAX_CPUS item
ClosedPublic
Actions

Authored by corvink on Mar 29 2023, 12:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 5:05 PM
Unknown Object (File)
Fri, Sep 27, 2:05 PM
Unknown Object (File)
Tue, Sep 10, 6:08 PM
Unknown Object (File)
Sun, Sep 8, 9:28 AM
Unknown Object (File)
Sat, Sep 7, 11:41 PM
Unknown Object (File)
Thu, Sep 5, 5:01 PM
Unknown Object (File)
Aug 13 2024, 12:33 AM
Unknown Object (File)
Aug 12 2024, 11:47 PM
View All 47 Files
Subscribers
bcran
imp
rew
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rG82622189fe02: bhyve: add QEMU_FWCFG_INDEX_MAX_CPUS item
rG305edaa47918: bhyve: add QEMU_FWCFG_INDEX_MAX_CPUS item
Summary

Requested-by: coreboot

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50646
Build 47537: arc lint + arc unit

Event Timeline

corvink created this revision.Mar 29 2023, 12:44 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMar 29 2023, 12:44 PM
corvink requested review of this revision.Mar 29 2023, 12:44 PM
Harbormaster completed remote builds in B50646: Diff 119604.Mar 29 2023, 12:44 PM
rew added a subscriber: rew.Mar 29 2023, 3:17 PM
rew added inline comments.
usr.sbin/bhyve/qemu_fwcfg.c
183

not suggesting for this review

but this could probably return EEXIST?

235

inverted error?

240–242

()'s on return

also, why the uint8_t cast on fwcfg_max_cpus?

rew mentioned this in D39316: bhyve/fwcfg: add QEMU_FWCFG_INDEX_NB_CPUS item.Mar 29 2023, 5:20 PM
corvink updated this revision to Diff 119655.Mar 30 2023, 5:56 AM
  • fix suggested style issues
Harbormaster completed remote builds in B50673: Diff 119655.Mar 30 2023, 5:56 AM
corvink marked 3 inline comments as done.Mar 30 2023, 5:57 AM
corvink added inline comments.
usr.sbin/bhyve/qemu_fwcfg.c
183

D39338

markj added inline comments.Apr 3 2023, 6:17 PM
usr.sbin/bhyve/qemu_fwcfg.c
238

Since this looks a bit odd, I'd add a comment noting that we don't support CPU hotplug (assuming that that's the reason for setting it equal to guest_ncpus and not maxcpus.

corvink updated this revision to Diff 120134.Apr 11 2023, 7:14 AM
corvink marked an inline comment as done.
  • add comment to explain that we don't support cpu hotplug
corvink marked an inline comment as done.Apr 11 2023, 7:14 AM
Harbormaster completed remote builds in B50831: Diff 120134.Apr 11 2023, 7:15 AM
markj accepted this revision as: markj.Apr 11 2023, 2:16 PM
This revision is now accepted and ready to land.Apr 11 2023, 2:16 PM
Closed by commit rG305edaa47918: bhyve: add QEMU_FWCFG_INDEX_MAX_CPUS item (authored by corvink). · Explain WhyApr 12 2023, 7:35 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG305edaa47918: bhyve: add QEMU_FWCFG_INDEX_MAX_CPUS item.
corvink added a commit: rG82622189fe02: bhyve: add QEMU_FWCFG_INDEX_MAX_CPUS item.Apr 28 2023, 10:41 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
21 lines

Diff 119604

View Options

usr.sbin/bhyve/qemu_fwcfg.c

Loading...