Page MenuHomeFreeBSD

committers-doc.dot: bring file up to date
ClosedPublic

Authored by fernape on Mar 29 2023, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 23 2024, 2:40 PM
Unknown Object (File)
Sep 22 2024, 3:43 AM
Unknown Object (File)
Sep 18 2024, 12:26 PM
Unknown Object (File)
Sep 17 2024, 8:56 PM
Unknown Object (File)
Sep 17 2024, 1:54 PM
Unknown Object (File)
Sep 17 2024, 8:34 AM
Unknown Object (File)
Sep 16 2024, 9:02 PM
Unknown Object (File)
Sep 16 2024, 1:07 AM
Subscribers

Details

Summary

This file was terribly outdated. If this is something we want, and this review is accepted I will do the same for ports and src.

Test Plan

This is difficult to test, but apply the patch and run:

dot -T png -o file.png committers-doc.dot

The generated file can be seen here

What I did was to take the current value of internal/admin/access for the doc
repository, do some grep -v to get the people who don't have access anymore
and then dig a bit the output of git log.

Note that I am unable to find when the commit bit for jim@ was taking in.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50638
Build 47529: arc lint + arc unit

Event Timeline

fernape edited the summary of this revision. (Show Details)
fernape added reviewers: doceng, docs.

Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).

share/misc/committers-doc.dot
64

s/salvadore[label/salvadore [label/

92

s/Apesteguia\fernape/Apesteguia\nfernape/

(\n missing)

Fix a couple of issues spotted by bcr@

This revision is now accepted and ready to land.Mar 29 2023, 4:38 PM
share/misc/committers-doc.dot
64

Actually I fixed this line and mistakenly moved salvadore@ to the alumni group :-S

Thanks a lot for this careful review.

92

Thanks!

Excellent, more eyes catch more bugs.
Good work, approved also by me!

This revision was automatically updated to reflect the committed changes.