Page MenuHomeFreeBSD
Differential D39302

amd64 wakeup: recalculate ssb/rngds mitigations after APICs are woken
ClosedPublic
Actions

Authored by kib on Mar 29 2023, 12:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 3:04 PM
Unknown Object (File)
Wed, Nov 13, 1:39 PM
Unknown Object (File)
Wed, Nov 13, 6:11 AM
Unknown Object (File)
Wed, Nov 13, 5:50 AM
Unknown Object (File)
Wed, Nov 13, 1:26 AM
Unknown Object (File)
Mon, Nov 4, 2:37 PM
Unknown Object (File)
Sat, Nov 2, 10:03 AM
Unknown Object (File)
Sat, Oct 19, 12:41 PM
View All 75 Files
Subscribers
henrix_camandro.org
imp
manu

Details

Reviewers
markj
emaste
dchagin
jhb
Commits
rGcd137909c309: amd64 wakeup: recalculate mitigations after APICs are woken
Summary
APICs are needed to broadcast IPIs for MSR writes.

PR:     270489
Tested by:      dchagin

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Mar 29 2023, 12:49 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 29 2023, 12:49 AM
kib requested review of this revision.Mar 29 2023, 12:49 AM
guest-patmaddox added a subscriber: guest-patmaddox.Mar 29 2023, 2:29 AM
dchagin accepted this revision.Mar 29 2023, 8:42 AM
dchagin added inline comments.
sys/amd64/acpica/acpi_wakeup.c
300–301

q just for curiosity: why to not move all of this below intr_resume?

This revision is now accepted and ready to land.Mar 29 2023, 8:42 AM
emaste accepted this revision.Mar 29 2023, 1:03 PM
manu added a subscriber: manu.Mar 29 2023, 1:25 PM

Fix the issue for me on my whiskeylake laptop.

Thanks.

kib updated this revision to Diff 119612.Mar 29 2023, 1:42 PM
kib marked an inline comment as done.

Move everything after APICs are resumed.

This revision now requires review to proceed.Mar 29 2023, 1:42 PM
manu added a comment.Mar 29 2023, 1:56 PM

Last version still work on my laptop.

markj added inline comments.Mar 29 2023, 2:15 PM
sys/amd64/acpica/acpi_wakeup.c
299–300

It looks like this comment should move to before the identify_cpu_ext_features() call above.

kib marked an inline comment as done.Mar 29 2023, 2:26 PM
kib added inline comments.
sys/amd64/acpica/acpi_wakeup.c
300–301

I tried to be conservative and recalculate as much as possible right after identify_cpu().

kib updated this revision to Diff 119614.Mar 29 2023, 2:26 PM

Move comment back.

emaste accepted this revision.Mar 29 2023, 2:30 PM
This revision is now accepted and ready to land.Mar 29 2023, 2:30 PM
dchagin accepted this revision.Mar 29 2023, 3:07 PM

confirm last ver work on stable/13.2 Intel i5-8265U SSBD, IBPB, MCUOPT

henrix_camandro.org added a subscriber: henrix_camandro.org.Mar 29 2023, 3:45 PM

Just FWIW the patch does fix the issue for me too. Thanks a lot everyone!

jhb accepted this revision.Mar 29 2023, 6:41 PM
Closed by commit rGcd137909c309: amd64 wakeup: recalculate mitigations after APICs are woken (authored by kib). · Explain WhyMar 29 2023, 6:46 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGcd137909c309: amd64 wakeup: recalculate mitigations after APICs are woken.
guest-patmaddox removed a subscriber: guest-patmaddox.Jul 29 2023, 5:37 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
acpica/
12 lines

Diff 119636

View Options

sys/amd64/acpica/acpi_wakeup.c

Loading...