Paths

Table of Contentst

Differential D39289

build: glibc on Linux defines explicit_bzero in <string.h>.
ClosedPublic
Actions

Authored by jhb on Mar 27 2023, 5:01 PM.

Tags

None

Referenced Files

	F102060292: D39289.diff
	Thu, Nov 7, 3:11 AM

	Unknown Object (File)
	Mon, Oct 21, 3:17 PM

	Unknown Object (File)
	Oct 5 2024, 10:01 AM

	Unknown Object (File)
	Sep 26 2024, 10:45 PM

	Unknown Object (File)
	Sep 24 2024, 8:52 AM

	Unknown Object (File)
	Sep 24 2024, 3:50 AM

	Unknown Object (File)
	Sep 24 2024, 1:12 AM

	Unknown Object (File)
	Sep 23 2024, 3:20 AM

View All 48 Files

Subscribers

Details

Reviewers

jrtc27
emaste
imp

Commits

rGac6b2b4344cd: build: glibc on Linux defines explicit_bzero in <string.h>.

Summary

Don't install strings.h on such systems. The local prototype doesn't
match the native Linux one when built as C++ breaking the build of
config(8) as a bootstrap tool on some Linux systems. If the missing
prototype becomes a problem in the future,
tools/build/cross-build/include/linux/strings.h can be patched to add

Obtained from: CheriBSD
Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 27 2023, 5:01 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 27 2023, 5:01 PM

jhb requested review of this revision.Mar 27 2023, 5:01 PM

Harbormaster completed remote builds in B50606: Diff 119519.Mar 27 2023, 5:01 PM

commit message looks like it's missing something, but otherwise OK

that said we might want to migrate our code to memset_s or meset_explicit?

This revision is now accepted and ready to land.Mar 27 2023, 5:50 PM

Oh, yeah, a missing "it." at the end of the sentence.

agree with ed, but this is good for now.

Closed by commit rGac6b2b4344cd: build: glibc on Linux defines explicit_bzero in <string.h>. (authored by jhb). · Explain WhyMar 27 2023, 9:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGac6b2b4344cd: build: glibc on Linux defines explicit_bzero in <string.h>..

Revision Contents
Changeset List

Path

Size

tools/

build/

2 lines

Diff 119529

tools/build/Makefile

Loading...