Differential D39257

rc: Chase bfb202c4554a and remove ifconfig down/up for wpa_supplicant
ClosedPublic
Actions

Authored by cy on Mar 24 2023, 4:37 PM.

Details

Reviewers

Group Reviewers

wireless

Commits

rG052211e08c0e: rc: Chase bfb202c4554a and remove ifconfig down/up for wpa_supplicant

Summary

bfb202c4554a addresses the CTRL-EVENT-SCAN-FAILED. Upstream d807e289d
caused FreeBSD regression in driver_bsd.c, which this rc.d patch
worked around. As of bfb202c4554a this workaround is no longer needed.

MFC after: 10 days
X-MFC with: bfb202c4554a

Test Plan

Test with bfb202c4554a using wlan0 which is not a member of lagg0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cy created this revision.Mar 24 2023, 4:37 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2023, 4:37 PM

cy requested review of this revision.Mar 24 2023, 4:37 PM

I will abandon https://reviews.freebsd.org/D39247 in favour of this. Thanks.

This revision is now accepted and ready to land.Mar 24 2023, 4:53 PM

In D39257#893637, @bz wrote:

I will abandon https://reviews.freebsd.org/D39247 in favour of this. Thanks.

I'm sorry. I should have checked first before submitting my review. Created the patch this morning before coffee and before switching the KVM to $JOB.

Closed by commit rG052211e08c0e: rc: Chase bfb202c4554a and remove ifconfig down/up for wpa_supplicant (authored by cy). · Explain WhyMar 24 2023, 5:09 PM

This revision was automatically updated to reflect the committed changes.

cy added a commit: rG052211e08c0e: rc: Chase bfb202c4554a and remove ifconfig down/up for wpa_supplicant.

bz mentioned this in rGded53e898c7b: rc/WPA: driver_bsd.c: backout upstream IFF_ change and add logging.Jun 26 2023, 12:08 PM