cap_net tests: Skip tests if there is no connectivity
ClosedPublic
Actions

Authored by markj on Mar 24 2023, 12:39 AM.

Details

Reviewers

Commits

rG04622b63cde8: cap_net tests: Skip tests if there is no connectivity
rG7ee4066db129: cap_net tests: Skip tests if there is no connectivity

Summary

When testing cap_connect() and name/addr lookup functions, skip tests if
we fail and the error is not ENOTCAPABLE. This makes the tests amenable
to running in CI without Internet connectivity.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 24 2023, 12:39 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2023, 12:39 AM

markj requested review of this revision.Mar 24 2023, 12:39 AM

Harbormaster completed remote builds in B50558: Diff 119372.Mar 24 2023, 12:39 AM

markj added a parent revision: D39241: cap_dns tests: Convert to ATF, avoid failing when lookups don't resolve.Mar 24 2023, 12:39 AM

oshogbo added inline comments.Mar 24 2023, 10:47 AM

lib/libcasper/services/cap_net/tests/net_test.c
144–145	Can't we switch the order like in previous?
205–209	ditto
238–239	ditto

markj added inline comments.Mar 24 2023, 5:03 PM

lib/libcasper/services/cap_net/tests/net_test.c
144–145	I should probably reorder the previous function instead. I did it that way initially but in some of the tests we expect the non-casper version to fail. So the pattern is: check the casper version, return ENOTCAPABLE if present try the system version, skip the test if it fails return success I'll change the other functions so that this is consistent.