Add /lib/capser to the rpath for anything linked against libcasper helpers.

[jhb]

This is an alternative to D39213. This does not yet remove the path from rtld's default path (which should be done as a followup at some point).

However, I also wonder at why we need these libraries hidden under /lib/casper at all. Other DSOs that we place under subdirectories like /lib/geom are things that are dlopen()'d and not linked to directly by end applications. Even the pam modules are in /usr/lib rather than /usr/lib/pam (and those are dlopen()'d). To me things that we explicitly link to with -l probably should be in /lib or /usr/lib.

[markj]

In D39222#892980, @jhb wrote:

This is an alternative to D39213. This does not yet remove the path from rtld's default path (which should be done as a followup at some point).

However, I also wonder at why we need these libraries hidden under /lib/casper at all. Other DSOs that we place under subdirectories like /lib/geom are things that are dlopen()'d and not linked to directly by end applications. Even the pam modules are in /usr/lib rather than /usr/lib/pam (and those are dlopen()'d). To me things that we explicitly link to with -l probably should be in /lib or /usr/lib.

This might be a holdover from the early days of casper, where it was a single system process?

[jhb]

Oops, I added the wrong Marius, thanks for fixing. :) If these used to be dlopen()'d but are now linked directly, then I think moving them to /lib and retiring /lib/casper altogether is the better fix than this. It would also avoid requiring ports that use casper to start using -rpath (which is a prerequisite for removing it from rtld's default search path).

[markj]

In D39222#893162, @jhb wrote:

Oops, I added the wrong Marius, thanks for fixing. :) If these used to be dlopen()'d but are now linked directly, then I think moving them to /lib and retiring /lib/casper altogether is the better fix than this. It would also avoid requiring ports that use casper to start using -rpath (which is a prerequisite for removing it from rtld's default search path).

That seems sensible. I can't see how it would break anything.

[oshogbo]

I don't mind also moving them simply to /lib.