Page MenuHomeFreeBSD

makefs: correct iso9660 Rock Ridge TF timestamps
ClosedPublic

Authored by emaste on Mar 22 2023, 11:49 PM.
Tags
None
Referenced Files
F97712198: D39221.diff
Mon, Sep 30, 10:21 PM
F97547608: D39221.id119301.diff
Mon, Sep 30, 12:32 AM
F97547602: D39221.id.diff
Mon, Sep 30, 12:32 AM
F97534118: D39221.id119323.diff
Sun, Sep 29, 10:56 PM
Unknown Object (File)
Tue, Sep 17, 11:41 AM
Unknown Object (File)
Aug 4 2024, 2:35 PM
Unknown Object (File)
Jul 29 2024, 1:22 AM
Unknown Object (File)
Jul 10 2024, 2:25 AM
Subscribers

Details

Summary
The bit definitions for the TF_* timestamp bits (TF_MODIFY, etc.) were
incorrect, and timestamps were written in the wrong order.

See RRIP 4.1.6 Description of the "TF" System Use Entry for details.

PR:             203531

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.
jrtc27 added a subscriber: jrtc27.

This matches my reading of the spec

This revision is now accepted and ready to land.Mar 23 2023, 12:47 AM
usr.sbin/makefs/cd9660/iso9660_rrip.h
63–65

these don't make sense - the first two are not used, the third is p->attr.rr_entry.NM.flags[0] = (unsigned char) NM_PARENT; (i.e., 0x200 cast to a byte)

to be dealt with later