Page MenuHomeFreeBSD

sys: Stop enabling -Wnested-externs.
ClosedPublic

Authored by jhb on Mar 22 2023, 6:01 PM.
Tags
None
Referenced Files
F96911202: D39214.diff
Fri, Sep 27, 4:08 AM
F96813943: D39214.diff
Thu, Sep 26, 5:54 PM
Unknown Object (File)
Thu, Sep 26, 4:14 AM
Unknown Object (File)
Mon, Sep 23, 2:08 PM
Unknown Object (File)
Mon, Sep 23, 4:33 AM
Unknown Object (File)
Sun, Sep 22, 11:22 PM
Unknown Object (File)
Sat, Sep 21, 5:49 PM
Unknown Object (File)
Wed, Sep 18, 5:04 PM
Subscribers

Details

Summary

clang doesn't implement this warning, so violations are only caught by
GCC. It is also no longer a common practice to use this as it was in
the original BSD code, so the need for the warning is not as important
as when it was used to do cleanups 20 years ago. A recent commit
(c3179891f897d840f578a5139839fcacb587c96d) triggers this warning on
GCC, but that commit uses nested externs purposefully.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable