libpfctl: Don't pass stack garbage to free.
ClosedPublic
Actions

Authored by jhb on Mar 22 2023, 2:57 AM.

Details

Reviewers

kp
mjg

Commits

rGf9c32827759b: libpfctl: Don't pass stack garbage to free.
rGb086848fc086: libpfctl: Don't pass stack garbage to free.
rG48c519be0e80: libpfctl: Don't pass stack garbage to free.

Summary

GCC 9 on stable/12 reports a -Wmaybe-uninitialized error for the call
to free in _pfctl_clear_states.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50510
Build 47401: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 22 2023, 2:57 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 22 2023, 2:57 AM

jhb requested review of this revision.Mar 22 2023, 2:57 AM

Harbormaster completed remote builds in B50510: Diff 119228.Mar 22 2023, 2:57 AM

mjg added a subscriber: mjg.Mar 22 2023, 4:50 AM

mjg added inline comments.

lib/libpfctl/libpfctl.c
1191	but the var is unused to begin with? modulo the bogus free call

mjg accepted this revision.Mar 22 2023, 4:57 AM

mjg added inline comments.

lib/libpfctl/libpfctl.c
1191	huh i somehow did not connect that you removed it altogether, apologies :)

This revision is now accepted and ready to land.Mar 22 2023, 4:57 AM

Closed by commit rG48c519be0e80: libpfctl: Don't pass stack garbage to free. (authored by jhb). · Explain WhyMar 22 2023, 7:36 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG48c519be0e80: libpfctl: Don't pass stack garbage to free..

jhb added a commit: rGb086848fc086: libpfctl: Don't pass stack garbage to free..Sep 6 2023, 9:57 PM

jhb added a commit: rGf9c32827759b: libpfctl: Don't pass stack garbage to free..Sep 6 2023, 10:03 PM

Revision Contents
Changeset List

Path

Size

lib/

libpfctl/

libpfctl.c

2 lines

Diff 119228

View Options

libpfctl: Don't pass stack garbage to free.ClosedPublicActions