Page MenuHomeFreeBSD

kerneldump: Inline dump_savectx() into its callers
ClosedPublic

Authored by markj on Mar 18 2023, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 9:31 PM
Unknown Object (File)
Wed, Nov 6, 11:54 PM
Unknown Object (File)
Oct 17 2024, 3:49 PM
Unknown Object (File)
Oct 17 2024, 1:56 AM
Unknown Object (File)
Oct 16 2024, 1:37 AM
Unknown Object (File)
Oct 14 2024, 5:55 PM
Unknown Object (File)
Oct 14 2024, 6:42 AM
Unknown Object (File)
Oct 13 2024, 2:45 AM
Subscribers

Details

Summary

The callers of dump_savectx() (i.e., doadump() and livedump_start())
subsequently call dumpsys()/minidumpsys(), which dump the calling
thread's stack when writing the dump. If dump_savectx() gets its own
stack frame, that frame might be clobbered when its caller later calls
dumpsys()/minidumpsys(), making it difficult for debuggers to unwind the
stack.

Fix this by making dump_savectx() a macro, so that savectx() is always
called directly by the function which subsequently calls
dumpsys()/minidumpsys().

This fixes stack unwinding for the panicking thread from arm64
minidumps. The same happened to work on amd64, but kgdb reports the
dump_savectx() calls as coming from dumpsys(), so in that case it
appears to work by accident.

Fixes: c9114f9f86f9 ("Add new vnode dumper to support live minidumps")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50457
Build 47348: arc lint + arc unit