makefs: move brelse into bread

[emaste]

Summary

Obtained from: NetBSD

commit 0a62dad69f6288b05e812c0fe293e61a37c25edd
Author: christos <[e-mail]>
Date:   Sun Jan 27 20:05:46 2013 +0000

    This works well enough to populate plain files in the root dir. creating
    directories fails.

[emaste]

Not yet tested

[imp]

I think these are necessary, but not quite sufficient. this will leak, but only some metadata writes

[mckusick]

The use of brelse in makefs/ffs/ffs_balloc.c is inconsistent. Assuming you are consistent in having bwrite brelse in both error and non-error cases there are two places in ffs_balloc.c that need to have brelse removed.

I have only checked the FFS code. All filesystem types need to have their use of brelse / bwrite checked.

usr.sbin/makefs/ffs/buf.c

142

Assuming your plan is that bwrite will always brelse(bp), error or not, then you need a brelse here.

149

You use bp in the next line after you have brelse'd it here. You need to check value and set errno equal zero before the brelse.

[emaste]

Update based on NetBSD commit:

commit 0c4125e1a19f619766092d0704164c091adac9fc
Author: christos <[e-mail]>
Date:   Mon Mar 13 22:10:30 2023 +0000

    modernize; release bpp and set it to NULL as the kernel does even if we
    never return here.

[emaste]

@mckusick I believe this update from NetBSD addresses the issue you raised.

[mckusick]

Now looks good. Sorry for the slow response.