Page MenuHomeFreeBSD

net: refactor if_clone.c #1
ClosedPublic

Authored by melifaro on Mar 13 2023, 10:44 AM.
Tags
None
Referenced Files
F102808757: D39046.diff
Sun, Nov 17, 11:24 AM
Unknown Object (File)
Oct 18 2024, 9:12 AM
Unknown Object (File)
Oct 8 2024, 6:48 AM
Unknown Object (File)
Oct 5 2024, 4:25 AM
Unknown Object (File)
Oct 5 2024, 2:09 AM
Unknown Object (File)
Oct 2 2024, 7:14 PM
Unknown Object (File)
Oct 2 2024, 12:47 PM
Unknown Object (File)
Oct 1 2024, 5:01 AM
Subscribers

Details

Summary
  • Add ifc_find_cloner()
  • Rename current ifc_find_cloner() to ifc_find_cloner_vnet()
  • Add ifc_find_cloner_match()

This change simplifies the code a bit and reduces the diff to
the netlink interface cloners merge (D39032).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50318
Build 47210: arc lint + arc unit

Event Timeline

Two non-blocking remarks.

sys/net/if_clone.c
199

That declaration probably needs to be before int error; in line 196, and separated from the assignment.

296

Would ifc_find_cloner_in_vnet() be better?

This revision is now accepted and ready to land.Mar 13 2023, 12:51 PM
glebius added inline comments.
sys/net/if_clone.c
199

+1 on that

This revision was automatically updated to reflect the committed changes.