tarfs: Repeat tests using GNU tar if available.
ClosedPublic
Actions

Authored by des on Mar 10 2023, 5:49 PM.

Details

Reviewers

sjg
stevek
asomers
ngie

Group Reviewers

Klara
tests

Commits

rG6cb78fa479c7: tarfs: Repeat tests using GNU tar if available.

Summary

Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50280
Build 47172: arc lint + arc unit

Event Timeline

des created this revision.Mar 10 2023, 5:49 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 10 2023, 5:49 PM

des requested review of this revision.Mar 10 2023, 5:49 PM

Harbormaster completed remote builds in B50280: Diff 118639.Mar 10 2023, 5:49 PM

LGTM. BTW, if you want this to run in FreeBSD's own CI, you should add gtar to https://github.com/freebsd/freebsd-ci/blob/1b56d3fb6cbec4ac4864e42cad056ecf0d0bf474/scripts/build/build-test_image-head.sh#L63 .

This revision is now accepted and ready to land.Mar 10 2023, 9:13 PM

This is a bit of additional boilerplate that would be nice to DRY. Not needed now, but it would be a good idea to create a for-loop that generates test cases for gtar/non-gtar within atf_init_test_cases, if possible.

tests/sys/fs/tarfs/tarfs_test.sh
139	(picking a line) These descriptions should really be improved -- they're referencing old issues, but not describing what's actually being tested.

ngie added inline comments.Mar 12 2023, 7:18 PM

tests/sys/fs/tarfs/tarfs_test.sh
36–38	Why does gtar require `--posix --absolute-names`, but bsdtar doesn't? (seems deserving of a comment)

sjg added inline comments.Mar 13 2023, 1:23 AM

tests/sys/fs/tarfs/tarfs_test.sh
36–38	A comment is a good idea. The gnutar man page (at least the version we use at work) speaks at length about how non-POSIX compatible it is. Using `--posix` is sufficient (in my tests) to get an approximately valid tar file from tarfs pov. Not sure about `--absolute-names`.

des marked 3 inline comments as done.Mar 14 2023, 12:23 AM

des added inline comments.

tests/sys/fs/tarfs/tarfs_test.sh
36–38	It prevents gtar from sanitising paths (e.g. `a/../b` -> `b` which bsdtar doesn't do), which would render the test partly moot because we want to verify that tarfs handles unsanitized paths correctly.
139	That's what we have a bug tracker and version history for. I'm not going to write an essay in the test description.