Page MenuHomeFreeBSD

tftpd: Make the -d option behave as documented.
ClosedPublic

Authored by des on Mar 7 2023, 11:03 PM.
Tags
None
Referenced Files
F108592673: D38965.id118619.diff
Sun, Jan 26, 6:02 PM
Unknown Object (File)
Fri, Jan 24, 5:21 PM
Unknown Object (File)
Thu, Jan 23, 6:34 PM
Unknown Object (File)
Mon, Jan 20, 12:39 AM
Unknown Object (File)
Fri, Jan 17, 3:50 AM
Unknown Object (File)
Nov 3 2024, 10:31 PM
Unknown Object (File)
Oct 29 2024, 3:17 PM
Unknown Object (File)
Oct 28 2024, 8:12 PM
Subscribers

Details

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 7 2023, 11:03 PM
des created this revision.
markj added a subscriber: markj.
markj added inline comments.
libexec/tftpd/tftpd.c
157

According to the documentation, these += and |= should be simple assignments. Maybe the documentation should be updated instead.

This revision is now accepted and ready to land.Mar 8 2023, 3:05 PM
libexec/tftpd/tftpd.c
157

I don't agree with that interpretation, at best I'd say it's vague on that point. This is the behavior that makes sense to me and debug_finds() gives me a headache so I'd rather leave well enough alone.

des marked an inline comment as done.Mar 8 2023, 6:04 PM
This revision was automatically updated to reflect the committed changes.