Page MenuHomeFreeBSD
Differential D38963

eqos: Mechanically convert to IfAPI
ClosedPublic
Actions

Authored by jhibbits on Mar 7 2023, 9:25 PM.
Tags
None
Referenced Files
F102829146: D38963.diff
Sun, Nov 17, 5:28 PM
Unknown Object (File)
Tue, Nov 12, 8:43 PM
Unknown Object (File)
Wed, Nov 6, 9:10 PM
Unknown Object (File)
Sun, Oct 27, 7:42 PM
Unknown Object (File)
Oct 13 2024, 4:00 PM
Unknown Object (File)
Sep 25 2024, 12:33 AM
Unknown Object (File)
Sep 20 2024, 4:01 PM
Unknown Object (File)
Sep 20 2024, 1:17 PM
View All 33 Files
Subscribers
imp
zlei

Details

Reviewers
sos
zlei
Group Reviewers
network
Commits
rGa472fd7a5737: eqos: Mechanically convert to IfAPI

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50211
Build 47103: arc lint + arc unit

Event Timeline

jhibbits created this revision.Mar 7 2023, 9:25 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 7 2023, 9:25 PM
jhibbits requested review of this revision.Mar 7 2023, 9:25 PM
Harbormaster completed remote builds in B50211: Diff 118498.Mar 7 2023, 9:25 PM
zlei accepted this revision as: zlei.Mar 8 2023, 7:00 AM
zlei added a subscriber: zlei.

Looks good to me.

sys/dev/eqos/if_eqos.c
1216

No local variable ifp.

This revision is now accepted and ready to land.Mar 8 2023, 7:00 AM
jhibbits marked an inline comment as done.Mar 8 2023, 2:55 PM
jhibbits added inline comments.
sys/dev/eqos/if_eqos.c
1216

Huh, I wonder how it compiled, then. Very strange.

Closed by commit rGa472fd7a5737: eqos: Mechanically convert to IfAPI (authored by jhibbits). · Explain WhyMar 8 2023, 3:16 PM
This revision was automatically updated to reflect the committed changes.
jhibbits marked an inline comment as done.
jhibbits added a commit: rGa472fd7a5737: eqos: Mechanically convert to IfAPI.
zlei added inline comments.Mar 8 2023, 4:27 PM
sys/dev/eqos/if_eqos.c
1216

Huh, I wonder how it compiled, then. Very strange.

if_eqos is driver for RK356X SOC Ethernet QoS controller. That is in arm machines. IIUC it will not be built with amd64/conf/GENERIC kernel config.

jhibbits added inline comments.Mar 8 2023, 4:52 PM
sys/dev/eqos/if_eqos.c
1216

It also apparently doesn't get built with arm64 LINT and I didn't build GENERIC before submitting the review.

Revision Contents
Changeset List

PathSize
sys/
dev/
eqos/
44 lines

Diff 118498

View Options

sys/dev/eqos/if_eqos.c

Loading...