Page MenuHomeFreeBSD

bhyve: Exit with EX_OSERR if init checkpoint or restore time failed
ClosedPublic

Authored by gusev.vitaliy_gmail.com on Mar 2 2023, 6:47 PM.
Tags
Referenced Files
Unknown Object (File)
Oct 7 2024, 6:17 AM
Unknown Object (File)
Oct 4 2024, 11:31 PM
Unknown Object (File)
Oct 1 2024, 5:26 AM
Unknown Object (File)
Sep 22 2024, 5:13 PM
Unknown Object (File)
Sep 18 2024, 10:34 AM
Unknown Object (File)
Sep 16 2024, 11:27 AM
Unknown Object (File)
Sep 15 2024, 1:27 PM
Unknown Object (File)
Sep 10 2024, 6:52 PM

Details

Summary

Part of Capsicum integration for snapshots.

Sponsored by: vStack

Test Plan

Run VM, Suspend, Resume.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
usr.sbin/bhyve/bhyverun.c
1582

pthread_create() returns a positive error number in the failure case, and this check won't catch it. I suspect it should just check init_checkpoint_thread(ctx) != 0.

This revision is now accepted and ready to land.Mar 2 2023, 10:03 PM

Fix note, use init_checkpoint_thread(ctx) != 0

This revision now requires review to proceed.Mar 3 2023, 11:47 AM
gusev.vitaliy_gmail.com added inline comments.
usr.sbin/bhyve/bhyverun.c
1582

Done.

This revision is now accepted and ready to land.Mar 3 2023, 2:27 PM