bhyveload: Address compiler warnings and bump WARNS
ClosedPublic
Actions

Authored by markj on Mar 1 2023, 2:57 PM.

Details

Reviewers

rew
jhb
corvink

Group Reviewers

bhyve

Commits

rGcc7b54d6ec76: bhyveload: Address compiler warnings and bump WARNS
rGad43dd69cec7: bhyveload: Address compiler warnings and bump WARNS

Summary

Mostly sprinkle __unused. Also duplicate strings passed to addenv() so
that constant string literals can be passed. No functional change
intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50081
Build 46973: arc lint + arc unit

Event Timeline

markj created this revision.Mar 1 2023, 2:57 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 1 2023, 2:57 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Mar 1 2023, 2:57 PM

Harbormaster completed remote builds in B50081: Diff 118129.Mar 1 2023, 2:58 PM

markj added a parent revision: D38839: bhyvectl: Address compiler warnings and bump WARNS.Mar 1 2023, 2:58 PM

rew accepted this revision as: rew.Mar 1 2023, 4:37 PM

This revision is now accepted and ready to land.Mar 1 2023, 4:37 PM

jhb accepted this revision.Mar 1 2023, 6:20 PM

corvink accepted this revision.Mar 2 2023, 6:50 AM

Closed by commit rGad43dd69cec7: bhyveload: Address compiler warnings and bump WARNS (authored by markj). · Explain WhyMar 3 2023, 4:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGad43dd69cec7: bhyveload: Address compiler warnings and bump WARNS.

markj added a commit: rGcc7b54d6ec76: bhyveload: Address compiler warnings and bump WARNS.Mar 13 2023, 3:54 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyveload/

Makefile

2 lines

bhyveload.c

68 lines

Diff 118129

View Options

usr.sbin/bhyveload/Makefile