Page MenuHomeFreeBSD

netmap: Fix compiler warnings in tools
ClosedPublic

Authored by markj on Feb 23 2023, 11:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 1:03 PM
Unknown Object (File)
Sun, Nov 10, 1:03 PM
Unknown Object (File)
Sun, Nov 10, 1:02 PM
Unknown Object (File)
Fri, Nov 8, 3:58 AM
Unknown Object (File)
Thu, Nov 7, 10:12 PM
Unknown Object (File)
Thu, Nov 7, 6:31 PM
Unknown Object (File)
Wed, Nov 6, 3:35 PM
Unknown Object (File)
Wed, Nov 6, 3:23 PM
Subscribers

Details

Summary
  • Remove write-only variables, or hide them in cases where their use is conditional or commented out.
  • Check for errors from cmd_apply() in nmreplay.
  • Use ANSI C definitions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49984
Build 46876: arc lint + arc unit

Event Timeline

tools/tools/netmap/lb.c
392

This one gives a compile error with clang 15.

vmaffione added inline comments.
tools/tools/netmap/pkt-gen.c
1524

why not dropping this?

1552

why not dropping this? It looks like leftover code

This revision now requires changes to proceed.Feb 26 2023, 3:41 PM
tools/tools/netmap/pkt-gen.c
1552

There are some commented-out prints that reference rx. Should I remove those as well?

Drop commented-out lines in pkt-gen.

Yeah, if not used since you are here please clean it up.

This revision is now accepted and ready to land.Feb 27 2023, 5:26 PM
This revision was automatically updated to reflect the committed changes.