Differential D38735

linux(4): Migrate to IfAPI
ClosedPublic
Actions

Authored by dchagin on Feb 22 2023, 8:22 PM.

Tags

Referenced Files

	F102379841: D38735.id117783.diff
	Mon, Nov 11, 11:37 AM

	Unknown Object (File)
	Thu, Oct 31, 11:26 PM

	Unknown Object (File)
	Sun, Oct 20, 6:55 PM

	Unknown Object (File)
	Sat, Oct 19, 7:04 PM

	Unknown Object (File)
	Sat, Oct 19, 12:03 AM

	Unknown Object (File)
	Oct 5 2024, 5:32 AM

	Unknown Object (File)
	Oct 1 2024, 7:15 PM

	Unknown Object (File)
	Sep 27 2024, 2:39 PM

View All 75 Files

Subscribers

Details

Reviewers

jhibbits
melifaro

Group Reviewers

Linux Emulation

Commits

rG6c5786fd37cb: linux(4): Migrate to IfAPI

Summary

Migrate linux and linprocfs to use the IfAPI interfaces instead of
direct ifnet accesses.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Feb 22 2023, 8:22 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2023, 8:22 PM

dchagin requested review of this revision.Feb 22 2023, 8:22 PM

Harbormaster completed remote builds in B49969: Diff 117783.Feb 22 2023, 8:22 PM

dchagin added reviewers: jhibbits, melifaro.Feb 22 2023, 8:23 PM

dchagin added a parent revision: D38714: linux(4): Consolidate a FreeBSD interface names translation code.

dchagin added a reviewer: Linux Emulation.Feb 26 2023, 11:24 AM

dchagin added a project: Linux Emulation.

jhibbits accepted this revision.Feb 27 2023, 12:38 AM

jhibbits added inline comments.

sys/compat/linprocfs/linprocfs.c
1492	Just style, do we need the spaces here?

This revision is now accepted and ready to land.Feb 27 2023, 12:38 AM

ah, casts and sizeof's are not followed by a space. so, whitespaces are gone
Thank you!

This revision now requires review to proceed.Feb 27 2023, 10:19 AM

Harbormaster completed remote builds in B50044: Diff 117995.Feb 27 2023, 10:19 AM

jhibbits accepted this revision.Mar 1 2023, 4:40 PM

This revision is now accepted and ready to land.Mar 1 2023, 4:40 PM

jhibbits mentioned this in D38609: linux: Enter network epoch before iterating over interfaces..Mar 1 2023, 9:07 PM

ugh, bug found in ifconf code,
linux_ifconf_ifaddr_cb2() should return 1 as if_foreach_addr_type()
counts from 0, so addrs always is 0 and linux_ifconf_ifnet_cb2() always
adds cruft entries with address 0. Linux skips interfaces not running and without addresses .

This revision now requires review to proceed.Mar 2 2023, 9:15 AM

Harbormaster completed remote builds in B50097: Diff 118167.Mar 2 2023, 9:15 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2023, 9:13 AM

Closed by commit rG6c5786fd37cb: linux(4): Migrate to IfAPI (authored by dchagin). · Explain Why

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG6c5786fd37cb: linux(4): Migrate to IfAPI.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linprocfs/

72 lines

linux/

4 lines

160 lines

124 lines

Diff 118308

sys/compat/linprocfs/linprocfs.c

Loading...

sys/compat/linux/linux.h

Loading...

sys/compat/linux/linux.c

Loading...

sys/compat/linux/linux_ioctl.c

Loading...