Page MenuHomeFreeBSD

linux(4): Migrate to IfAPI
ClosedPublic

Authored by dchagin on Feb 22 2023, 8:22 PM.
Referenced Files
Unknown Object (File)
Thu, Oct 31, 11:26 PM
Unknown Object (File)
Sun, Oct 20, 6:55 PM
Unknown Object (File)
Sat, Oct 19, 7:04 PM
Unknown Object (File)
Sat, Oct 19, 12:03 AM
Unknown Object (File)
Oct 5 2024, 5:32 AM
Unknown Object (File)
Oct 1 2024, 7:15 PM
Unknown Object (File)
Sep 27 2024, 2:39 PM
Unknown Object (File)
Sep 24 2024, 8:34 AM
Subscribers

Details

Summary

Migrate linux and linprocfs to use the IfAPI interfaces instead of
direct ifnet accesses.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits added inline comments.
sys/compat/linprocfs/linprocfs.c
1492

Just style, do we need the spaces here?

This revision is now accepted and ready to land.Feb 27 2023, 12:38 AM

ah, casts and sizeof's are not followed by a space. so, whitespaces are gone
Thank you!

This revision now requires review to proceed.Feb 27 2023, 10:19 AM
This revision is now accepted and ready to land.Mar 1 2023, 4:40 PM

ugh, bug found in ifconf code,
linux_ifconf_ifaddr_cb2() should return 1 as if_foreach_addr_type()
counts from 0, so addrs always is 0 and linux_ifconf_ifnet_cb2() always
adds cruft entries with address 0. Linux skips interfaces not running and without addresses .

This revision now requires review to proceed.Mar 2 2023, 9:15 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2023, 9:13 AM
This revision was automatically updated to reflect the committed changes.