Page MenuHomeFreeBSD
Differential D38733

Delete obsolete Solaris compat header file `stdlib.h`
ClosedPublic
Actions

Authored by zlei on Feb 22 2023, 5:54 PM.
Tags
None
Referenced Files
F97813937: D38733.diff
Tue, Oct 1, 9:18 AM
Unknown Object (File)
Mon, Sep 23, 8:42 PM
Unknown Object (File)
Wed, Sep 18, 11:42 PM
Unknown Object (File)
Tue, Sep 17, 5:49 AM
Unknown Object (File)
Wed, Sep 11, 3:49 PM
Unknown Object (File)
Wed, Sep 11, 3:49 PM
Unknown Object (File)
Wed, Sep 11, 3:49 PM
Unknown Object (File)
Mon, Sep 9, 2:19 AM
View All 75 Files
Subscribers
imp
markj

Details

Reviewers
mmacy
mm
markj
Commits
rGb4eb5f81eead: Delete obsolete Solaris compat header file stdlib.h
rG95f418fe2a0f: Delete obsolete Solaris compat header file stdlib.h
rG7f0ebf0876c8: Delete obsolete Solaris compat header file stdlib.h
Summary

This drops function getexecname() redirection.

Historically getexecname() is a compatibility definition. Since openzfs has its own implementation of function getexecname() in libspl and has been merged into base, the compat header file stdlib.h is no longer needed and should not be used.

Also without this fix libspl will end up an incompatible version of getprogname() with libc. In particular, if zfs is enabled, programs such as pgrep in /rescue can be wrongly statically linked with libspl and will not function properly.

PR: 269738
MFC after: 1 week
Fixes: 9e5787d2284e Merge OpenZFS support in to HEAD

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Feb 22 2023, 5:54 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2023, 5:54 PM
zlei requested review of this revision.Feb 22 2023, 5:54 PM
zlei mentioned this in D38716: pkill(1): fix /rescue/pgrep not working.
zlei edited the summary of this revision. (Show Details)Feb 22 2023, 5:58 PM
markj added a subscriber: markj.Feb 22 2023, 5:58 PM
  1. This file can simply be removed, no?
  2. Will this break the use of getexecname() in contrib/opensolaris/tools/ctf/common/utils.c? I think we can simply change that to use getprogname(). Or even better, get rid of getpname() and modify the single caller in dump.c to use getprogname() directly.
zlei added a comment.Feb 22 2023, 6:05 PM
In D38733#881446, @markj wrote:
  1. This file can simply be removed, no?
  2. Will this break the use of getexecname() in contrib/opensolaris/tools/ctf/common/utils.c? I think we can simply change that to use getprogname(). Or even better, get rid of getpname() and modify the single caller in dump.c to use getprogname() directly.

It may break contrib/opensolaris/tools/ctf/common/utils.c, I'll check that.

zlei added a comment.Feb 23 2023, 3:53 AM
In D38733#881451, @zlei wrote:
In D38733#881446, @markj wrote:
  1. This file can simply be removed, no?
  2. Will this break the use of getexecname() in contrib/opensolaris/tools/ctf/common/utils.c? I think we can simply change that to use getprogname(). Or even better, get rid of getpname() and modify the single caller in dump.c to use getprogname() directly.

It may break contrib/opensolaris/tools/ctf/common/utils.c, I'll check that.

Yes you're right !

ctfdump is actually linked against getprogname() in libc. So we can safely get rid of getpname().

BTW, after debugging with lldb I can confirm ztest is calling getprogname() in libspl.

zlei added a parent revision: D38740: ctfdump: Use getprogname().Feb 23 2023, 4:47 AM
markj added a comment.Feb 23 2023, 3:01 PM
In D38733#881594, @zlei wrote:
In D38733#881451, @zlei wrote:
In D38733#881446, @markj wrote:
  1. This file can simply be removed, no?
  2. Will this break the use of getexecname() in contrib/opensolaris/tools/ctf/common/utils.c? I think we can simply change that to use getprogname(). Or even better, get rid of getpname() and modify the single caller in dump.c to use getprogname() directly.

It may break contrib/opensolaris/tools/ctf/common/utils.c, I'll check that.

Yes you're right !

ctfdump is actually linked against getprogname() in libc. So we can safely get rid of getpname().

And with D38740 we should be able to completely remove this stdlib.h header.

BTW, after debugging with lldb I can confirm ztest is calling getprogname() in libspl.

zlei updated this revision to Diff 117822.Feb 23 2023, 5:41 PM
zlei retitled this revision from zfs: Drop function getexecname() redirection to Delete unneeded Solaris compat header file `stdlib.h`.
zlei edited the summary of this revision. (Show Details)

Remove the compat header file stdlib.h

markj accepted this revision.Feb 23 2023, 5:45 PM
This revision is now accepted and ready to land.Feb 23 2023, 5:45 PM
zlei retitled this revision from Delete unneeded Solaris compat header file `stdlib.h` to Delete obsolete Solaris compat header file `stdlib.h`.Feb 23 2023, 5:46 PM
zlei edited the summary of this revision. (Show Details)
Closed by commit rG7f0ebf0876c8: Delete obsolete Solaris compat header file stdlib.h (authored by zlei). · Explain WhyFeb 23 2023, 6:10 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG7f0ebf0876c8: Delete obsolete Solaris compat header file stdlib.h.
zlei added a commit: rG95f418fe2a0f: Delete obsolete Solaris compat header file stdlib.h.Mar 2 2023, 2:57 AM
zlei added a commit: rGb4eb5f81eead: Delete obsolete Solaris compat header file stdlib.h.Mar 2 2023, 8:29 AM

Revision Contents
Changeset List

PathSize
cddl/
compat/
opensolaris/
include/

Diff 117822

View Options

cddl/compat/opensolaris/include/stdlib.h

Loading...