Page MenuHomeFreeBSD
Differential D38718

fusefs: fix a buffer overflow in the tests
ClosedPublic
Actions

Authored by asomers on Feb 22 2023, 12:34 AM.
Tags
None
Referenced Files
F102808671: D38718.diff
Sun, Nov 17, 11:22 AM
Unknown Object (File)
Wed, Nov 13, 1:06 AM
Unknown Object (File)
Mon, Nov 11, 4:46 PM
Unknown Object (File)
Mon, Oct 21, 1:17 PM
Unknown Object (File)
Mon, Oct 21, 1:17 PM
Unknown Object (File)
Mon, Oct 21, 1:17 PM
Unknown Object (File)
Mon, Oct 21, 1:17 PM
Unknown Object (File)
Mon, Oct 21, 1:04 PM
View All 45 Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rG3205b36fba10: fusefs: fix a buffer overflow in the tests
rG0c9df4afc239: fusefs: fix a buffer overflow in the tests
Summary

The actual overflow occured in the ReadAhead.readahead test.
Surprisingly it has never segfaulted or resulted in any bad behavior.

MFC after: 1 week
Sponsored by: Axcient

Test Plan

Added assertions to existing tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49964
Build 46856: arc lint + arc unit

Event Timeline

asomers created this revision.Feb 22 2023, 12:34 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2023, 12:34 AM
asomers requested review of this revision.Feb 22 2023, 12:34 AM
Harbormaster completed remote builds in B49939: Diff 117730.Feb 22 2023, 12:34 AM
emaste added inline comments.Feb 22 2023, 1:46 AM
tests/sys/fs/fusefs/io.cc
144

should this be sizeof(in.body-bytes) - sizeof(struct fuse_write_in) or so?
and another similar case or two

asomers added inline comments.Feb 22 2023, 3:19 PM
tests/sys/fs/fusefs/io.cc
144

Yes.

asomers updated this revision to Diff 117766.Feb 22 2023, 3:20 PM
  • Fix size comparisons during FUSE_WRITE
  • Add another size check in bmap.cc
Harbormaster completed remote builds in B49964: Diff 117766.Feb 22 2023, 3:20 PM
emaste accepted this revision.Feb 22 2023, 4:19 PM
This revision is now accepted and ready to land.Feb 22 2023, 4:19 PM
Closed by commit rG0c9df4afc239: fusefs: fix a buffer overflow in the tests (authored by asomers). · Explain WhyFeb 22 2023, 5:03 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG0c9df4afc239: fusefs: fix a buffer overflow in the tests.
asomers added a commit: rG3205b36fba10: fusefs: fix a buffer overflow in the tests.Mar 15 2023, 10:41 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
fs/
fusefs/
2 lines
3 lines
3 lines
2 lines
1 line
6 lines
2 lines

Diff 117766

View Options

tests/sys/fs/fusefs/bmap.cc

Loading...
View Options

tests/sys/fs/fusefs/fallocate.cc

Loading...
View Options

tests/sys/fs/fusefs/io.cc

Loading...
View Options

tests/sys/fs/fusefs/mockfs.hh

Loading...
View Options

tests/sys/fs/fusefs/setattr.cc

Loading...
View Options

tests/sys/fs/fusefs/utils.cc

Loading...
View Options

tests/sys/fs/fusefs/write.cc

Loading...