Page MenuHomeFreeBSD
Differential D38711

mlx5: Enter network epoch when using if_foreach()
ClosedPublic
Actions

Authored by jhibbits on Feb 21 2023, 9:09 PM.
Tags
None
Referenced Files
F96616656: D38711.diff
Wed, Sep 25, 6:19 PM
Unknown Object (File)
Mon, Sep 23, 8:56 PM
Unknown Object (File)
Mon, Sep 23, 10:23 AM
Unknown Object (File)
Mon, Sep 23, 1:49 AM
Unknown Object (File)
Sun, Sep 22, 6:22 PM
Unknown Object (File)
Wed, Sep 18, 2:52 PM
Unknown Object (File)
Tue, Sep 17, 4:36 PM
Unknown Object (File)
Tue, Sep 17, 7:33 AM
View All 35 Files
Subscribers
ae
imp
melifaro

Details

Reviewers
glebius
• hselasky
Group Reviewers
network
Commits
rG70510800d1ad: mlx5: Enter network epoch when using if_foreach()
Summary

IFNET_RLOCK() is not sufficient, the epoch needs entered.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Feb 21 2023, 9:09 PM
Herald added subscribers: ae, imp. · View Herald TranscriptFeb 21 2023, 9:09 PM
jhibbits requested review of this revision.Feb 21 2023, 9:09 PM
Harbormaster completed remote builds in B49931: Diff 117708.Feb 21 2023, 9:09 PM
• hselasky added a comment.Feb 22 2023, 10:04 AM

Hi,

I'm not sure if that will work, because there is a write_lock() inside mlx5_enable_roce_if_cb(), and that cannot be used inside an EPOCH section!

#define write_lock(_l)          rw_wlock(&(_l)->rw)
• hselasky added a comment.Feb 22 2023, 10:13 AM
In D38711#881214, @hselasky wrote:

Hi,

I'm not sure if that will work, because there is a write_lock() inside mlx5_enable_roce_if_cb(), and that cannot be used inside an EPOCH section!

#define write_lock(_l)          rw_wlock(&(_l)->rw)

Or am I wrong.

--HPS

melifaro added a subscriber: melifaro.Feb 22 2023, 10:27 AM
In D38711#881221, @hselasky wrote:
In D38711#881214, @hselasky wrote:

Hi,

I'm not sure if that will work, because there is a write_lock() inside mlx5_enable_roce_if_cb(), and that cannot be used inside an EPOCH section!

#define write_lock(_l)          rw_wlock(&(_l)->rw)

Or am I wrong.

--HPS

It's OK to use rwlocks/mutexes (and basically anything that don't sleep) in the (network) epoch.

• hselasky accepted this revision.Feb 22 2023, 10:42 AM

I'm good with this patch!

This revision is now accepted and ready to land.Feb 22 2023, 10:42 AM
Closed by commit rG70510800d1ad: mlx5: Enter network epoch when using if_foreach() (authored by jhibbits). · Explain WhyMar 6 2023, 4:24 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG70510800d1ad: mlx5: Enter network epoch when using if_foreach().

Revision Contents
Changeset List

PathSize
sys/
dev/
mlx5/
mlx5_ib/
5 lines

Diff 118400

View Options

sys/dev/mlx5/mlx5_ib/mlx5_ib_main.c

Loading...