net80211: introduce two extra ieee80211_notify_scan_done()
ClosedPublic
Actions

Authored by bz on Feb 18 2023, 1:25 AM.

Details

Reviewers

cy
enweiwu
lwhsu

Commits

rG61c5d5679ba8: net80211: introduce two extra ieee80211_notify_scan_done()
rG6104a9f9c520: net80211: introduce two extra ieee80211_notify_scan_done()
rG3f382eb23b9f: net80211: introduce two extra ieee80211_notify_scan_done()

Summary

We have multiple problems with scanning currently, one being that
an initial scan restarts itself and we are unable to start another
scan. wpa_supplicant in that case never gets scan results.
Add two extra calls to ieee80211_notify_scan_done() at the end of scans
(before possible restarts). That will get wpa_supplicant to query
can results and possibly start associating to a BSSID and get us out
of scan. This is kind-of a bandaid but on short notice helps to improve
some situations.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

This came out of a longer analysis of @enweiwu in D38508 and related revisions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49872
Build 46763: arc lint + arc unit

Event Timeline

bz created this revision.Feb 18 2023, 1:25 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptFeb 18 2023, 1:25 AM

bz requested review of this revision.Feb 18 2023, 1:25 AM

Harbormaster completed remote builds in B49872: Diff 117521.Feb 18 2023, 1:25 AM

I keep thinking that this is the two places when a scan finished and is started again without being stopped after all.

bz changed the visibility from "Public (No Login Required)" to "Subscribers".Feb 18 2023, 1:27 AM

bz changed the edit policy from "All Users" to "Subscribers".

bz mentioned this in D38807: WPA: backout upstream IFF_ change and add logging.Feb 27 2023, 10:28 PM

bz changed the visibility from "Subscribers" to "Public (No Login Required)".Aug 21 2023, 9:40 PM

bz added reviewers: cy, enweiwu, lwhsu.Sep 19 2023, 3:29 PM

bz edited subscribers, added: wireless; removed: enweiwu.Sep 20 2023, 3:20 PM

bz edited the summary of this revision. (Show Details)Sep 20 2023, 3:24 PM

bz retitled this revision from net80211: add extra ieee80211_notify_scan_done() calls to net80211: introduce two extra ieee80211_notify_scan_done().Sep 21 2023, 11:55 AM

bz edited the summary of this revision. (Show Details)

bz edited the test plan for this revision. (Show Details)

The patch looks reasonable. I'll try to test tonight.

I didn't have any problems before but the added scan notify does wake up wpa_supplicant, producing more output.

This revision is now accepted and ready to land.Sep 21 2023, 2:17 PM

Closed by commit rG3f382eb23b9f: net80211: introduce two extra ieee80211_notify_scan_done() (authored by bz). · Explain WhySep 21 2023, 5:38 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG3f382eb23b9f: net80211: introduce two extra ieee80211_notify_scan_done().

bz added a commit: rG6104a9f9c520: net80211: introduce two extra ieee80211_notify_scan_done().Oct 4 2023, 3:24 PM

bz added a commit: rG61c5d5679ba8: net80211: introduce two extra ieee80211_notify_scan_done().Oct 9 2023, 11:16 PM