config: error out on malformed env/hint lines
ClosedPublic
Actions

Authored by kevans on Feb 16 2023, 5:25 PM.

Details

Reviewers

imp
des
emaste

Commits

rGda8884202940: config: error out on malformed env/hint lines

Summary

We need these to be assignments, error out if they're not.

While we're here, tag errout as __printflike so that the compiler will
sanity check the format string + args.

CID: 1505293

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49856
Build 46747: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Feb 16 2023, 5:25 PM

kevans created this revision.

Harbormaster completed remote builds in B49856: Diff 117466.Feb 16 2023, 5:25 PM

kevans added a parent revision: D38641: config: push path() into moveifchanged().Feb 16 2023, 5:25 PM

kevans added a child revision: D38643: config: address a number of Coverity issues.

Looks good. I'd be tempted to separate the prinflike thing, but if not that's cool too.

This revision is now accepted and ready to land.Feb 16 2023, 5:33 PM

emaste accepted this revision.Feb 16 2023, 5:52 PM

Closed by commit rGda8884202940: config: error out on malformed env/hint lines (authored by kevans). · Explain WhyFeb 16 2023, 8:38 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGda8884202940: config: error out on malformed env/hint lines.

Revision Contents
Changeset List

Path

Size

usr.sbin/

config/

mkmakefile.cc

25 lines

Diff 117466

View Options

usr.sbin/config/mkmakefile.cc

config: error out on malformed env/hint linesClosedPublicActions