Page MenuHomeFreeBSD
Differential D38615

efivar: Allow NULL paths in build_dp
ClosedPublic
Actions

Authored by imp on Feb 15 2023, 7:51 PM.
Tags
None
Referenced Files
F102603225: D38615.id.diff
Thu, Nov 14, 4:13 PM
Unknown Object (File)
Mon, Oct 21, 4:25 AM
Unknown Object (File)
Fri, Oct 18, 11:06 PM
Unknown Object (File)
Oct 4 2024, 9:25 AM
Unknown Object (File)
Oct 4 2024, 5:02 AM
Unknown Object (File)
Oct 2 2024, 12:22 AM
Unknown Object (File)
Oct 1 2024, 9:11 PM
Unknown Object (File)
Sep 29 2024, 8:48 PM
View All 62 Files
Subscribers
None

Details

Reviewers
manu
corvink
asomers
Commits
rGcd475287ee5a: efivar: Allow NULL paths in build_dp
rG82c0aea8f3c2: efivar: Allow NULL paths in build_dp
rG49fd6affdbfe: efivar: Allow NULL paths in build_dp
Summary

Allow there ot be NULL paths in buildp. This lets us return the device
path to the partition, as well as to files on the partition.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49828
Build 46719: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 15 2023, 7:51 PM
imp created this revision.
Harbormaster completed remote builds in B49815: Diff 117325.Feb 15 2023, 7:51 PM
imp added a parent revision: D38614: efivar: Try harder to find label's efimedia.Feb 15 2023, 7:51 PM
imp added a child revision: D38616: efivar: support device paths as well as mounted paths in path_to_dp.
asomers accepted this revision.Feb 15 2023, 11:36 PM

I suppose this is ok, not that I know how to test it or anything. But do fix the typo in the commit message, and convert spaces to tabs in the code.

This revision is now accepted and ready to land.Feb 15 2023, 11:36 PM
imp added a comment.Feb 16 2023, 12:37 AM

will fix commit message before commit.

imp updated this revision to Diff 117348.Feb 16 2023, 12:40 AM

Update per review

This revision now requires review to proceed.Feb 16 2023, 12:40 AM
Harbormaster completed remote builds in B49828: Diff 117348.Feb 16 2023, 12:40 AM
manu accepted this revision.Feb 16 2023, 7:03 AM
This revision is now accepted and ready to land.Feb 16 2023, 7:03 AM
corvink accepted this revision.Feb 16 2023, 8:57 AM
Closed by commit rG49fd6affdbfe: efivar: Allow NULL paths in build_dp (authored by imp). · Explain WhyFeb 16 2023, 3:59 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG49fd6affdbfe: efivar: Allow NULL paths in build_dp.
imp added a commit: rG82c0aea8f3c2: efivar: Allow NULL paths in build_dp.Feb 19 2023, 12:49 AM
imp added a commit: rGcd475287ee5a: efivar: Allow NULL paths in build_dp.Feb 19 2023, 6:49 AM

Revision Contents
Changeset List

PathSize
lib/
libefivar/
24 lines

Diff 117348

View Options

lib/libefivar/efivar-dp-xlate.c

Loading...