Page MenuHomeFreeBSD

efivar: Try harder to find label's efimedia
ClosedPublic

Authored by imp on Feb 15 2023, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 3 2024, 8:58 PM
Unknown Object (File)
Oct 3 2024, 4:12 PM
Unknown Object (File)
Oct 1 2024, 4:05 PM
Unknown Object (File)
Oct 1 2024, 1:28 PM
Unknown Object (File)
Sep 28 2024, 9:19 AM
Unknown Object (File)
Sep 25 2024, 7:11 PM
Unknown Object (File)
Sep 25 2024, 7:11 PM
Unknown Object (File)
Sep 25 2024, 7:11 PM
Subscribers
None

Details

Summary

If there's no efimedia attribute on the provider, and the provider's a
glabel, then find the 'parent' geom. In this case, the provider's name
is label-type/name, but the geom's label will that of the underlying
device (eg ada0p1). If it is, recurisvely call find_geom_efimedia with
the geom's name, which shuold have the efimedia attribute.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 15 2023, 7:49 PM
imp created this revision.

I see nothing wrong with this, though I'm not very familiar with this library, and I don't know how to test it. However, there are two typos in your commit message, and the first line should read "libefivar" instead of "efivars".

lib/libefivar/efivar-dp-xlate.c
532
This revision is now accepted and ready to land.Feb 15 2023, 11:22 PM
imp retitled this revision from efivars: Try harder to find label's efimedia to libefivar: Try harder to find label's efimedia.Feb 16 2023, 12:26 AM
imp retitled this revision from libefivar: Try harder to find label's efimedia to efivar: Try harder to find label's efimedia.Feb 16 2023, 12:37 AM
This revision now requires review to proceed.Feb 16 2023, 12:40 AM
This revision is now accepted and ready to land.Feb 16 2023, 7:03 AM
This revision was automatically updated to reflect the committed changes.