Differential D38567

linuxkpi: Move `IS_ENABLED()` and friends to <linux/kconfig.h>
ClosedPublic
Actions

Authored by dumbbell on Feb 13 2023, 9:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 9 2024, 10:02 AM

	Unknown Object (File)
	Dec 8 2024, 4:20 PM

	Unknown Object (File)
	Dec 4 2024, 4:40 AM

	Unknown Object (File)
	Nov 10 2024, 1:00 PM

	Unknown Object (File)
	Oct 27 2024, 9:06 AM

	Unknown Object (File)
	Oct 25 2024, 5:42 PM

	Unknown Object (File)
	Oct 25 2024, 5:42 PM

	Unknown Object (File)
	Oct 25 2024, 5:42 PM

View All 70 Files

Subscribers

Details

Reviewers

manu
bz

Commits

rG070d7997501f: linuxkpi: Move `IS_ENABLED()` and friends to <linux/kconfig.h>
rG4b0552d5f4ea: linuxkpi: Move `IS_ENABLED()` and friends to <linux/kconfig.h>

Summary

The header is included in <linux/xarray.h> like it is on Linux. Some DRM code depends on this header "pollution".

This is part of the update of the DRM drivers to Linux 5.16.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Feb 13 2023, 9:30 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptFeb 13 2023, 9:30 PM

dumbbell requested review of this revision.Feb 13 2023, 9:30 PM

bz requested changes to this revision.Feb 13 2023, 10:28 PM

bz added a subscriber: bz.

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/kconfig.h
9	I think I or the FreeBSD Foundation would claim the copyright on those additions if separated out into an extra file. By themselves they weren't significant enough to claim Copyright back then but in a separate file we should. None of those people above hold the copyright on what came in to kernel.h in 4abbf816bf06a and now is below. Can you grab the entire header part from asm/unaligned.h (year 2020 is correct for when this was developed as well; got committed in Jan 2021).

This revision now requires changes to proceed.Feb 13 2023, 10:28 PM

Update the license header.

@bz: The header is fixed, thanks!

bz accepted this revision.Feb 14 2023, 10:11 PM

This revision is now accepted and ready to land.Feb 14 2023, 10:11 PM

Closed by commit rG4b0552d5f4ea: linuxkpi: Move `IS_ENABLED()` and friends to <linux/kconfig.h> (authored by dumbbell). · Explain WhyFeb 14 2023, 11:08 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG4b0552d5f4ea: linuxkpi: Move `IS_ENABLED()` and friends to <linux/kconfig.h>.

dumbbell added a commit: rG070d7997501f: linuxkpi: Move `IS_ENABLED()` and friends to <linux/kconfig.h>.Feb 16 2023, 11:57 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

78 lines

43 lines

1 line

Diff 117252

sys/compat/linuxkpi/common/include/linux/kconfig.h

Loading...

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...

sys/compat/linuxkpi/common/include/linux/xarray.h

Loading...