sys/intr: merge interrupt table uses of MAXCOMLEN into INTRNAME_LEN
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Feb 8 2023, 9:08 PM.

Details

Reviewers

Commits

rGb5f0f20e9bd1: intr: merge interrupt table uses of MAXCOMLEN into INTRNAME_LEN
rG5ad59b91535f: intr: merge interrupt table uses of MAXCOMLEN into INTRNAME_LEN

Summary

The repeated uses of MAXCOMLEN + 1 seem a bit hazardous. If there was
a future need to change the size, the repeats will be troublesome.
Merge everything into #define INTRNAME_LEN (matches the name used by
INTRNG).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49642
Build 46532: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Feb 8 2023, 9:08 PM

Herald added subscribers: jhibbits, imp. · View Herald TranscriptFeb 8 2023, 9:08 PM

ehem_freebsd_m5p.com requested review of this revision.Feb 8 2023, 9:08 PM

Harbormaster completed remote builds in B49642: Diff 116814.Feb 8 2023, 9:08 PM

ehem_freebsd_m5p.com added a child revision: D38454: sys: move handling of hw.intrnames/hw.intrcnt to architecture.Feb 8 2023, 9:23 PM

ehem_freebsd_m5p.com edited child revisions, added: D38116: sys/intr: switch to index vars from table size vars; removed: D38454: sys: move handling of hw.intrnames/hw.intrcnt to architecture.Feb 8 2023, 9:49 PM

markj accepted this revision.Feb 14 2023, 1:54 PM

This revision is now accepted and ready to land.Feb 14 2023, 1:54 PM

Closed by commit rG5ad59b91535f: intr: merge interrupt table uses of MAXCOMLEN into INTRNAME_LEN (authored by ehem_freebsd_m5p.com, committed by markj). · Explain WhyAug 17 2023, 10:12 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG5ad59b91535f: intr: merge interrupt table uses of MAXCOMLEN into INTRNAME_LEN.

markj added a commit: rGb5f0f20e9bd1: intr: merge interrupt table uses of MAXCOMLEN into INTRNAME_LEN.Aug 31 2023, 1:55 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

intr_machdep.c

9 lines

x86/

intr_machdep.c

13 lines

Diff 116814

View Options

sys/powerpc/powerpc/intr_machdep.c