This function has been around since 4.4BSD but was dropped upstream in 2020. This went unnoticed when tzcode was updated. Bring it back, but prepare for removing it before 14.0 is released.
MFC after: 3 days
Reported by: val@packett.cool
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
ping @cperciva as this is a regression in stable/13 which needs to be fixed before 13.2.
Comment Actions
Note that I chose to reimplement tzsetwall(3) as it was easy enough to do, but I'm not sure this is the right approach as it locks us into maintaining a patch in contributed code.
Comment Actions
it locks us into maintaining a patch in contributed code.
The burden of doing so is much lower than in the CVS or SVN days so I don't think it's a big deal.
| contrib/tzcode/localtime.c | ||
|---|---|---|
| 1544 | why not just inline this one? it's not being reused anywhere… | |
| contrib/tzcode/localtime.c | ||
|---|---|---|
| 1544 | The inline keyword is just a suggestion. The compiler is free to inline the function or not regardless of whether I ask it to, and I trust the compiler to make the right choice. The only difference the inline keyword makes is to suppress warnings when a header that defines static functions (e.g. <sys/endian.h>) is included in a translation unit which does not use them. | |