Page MenuHomeFreeBSD

tzcode: garbage collect references to tzsetwall
AbandonedPublic

Authored by val_packett.cool on Feb 6 2023, 8:13 PM.
Tags
None
Referenced Files
F96296306: D38409.id116641.diff
Tue, Sep 24, 10:00 AM
F96296256: D38409.id.diff
Tue, Sep 24, 10:00 AM
F96295738: D38409.diff
Tue, Sep 24, 9:52 AM
Unknown Object (File)
Mon, Sep 23, 4:21 PM
Unknown Object (File)
Sat, Sep 21, 10:17 AM
Unknown Object (File)
Sat, Sep 7, 10:24 PM
Unknown Object (File)
Thu, Sep 5, 11:02 PM
Unknown Object (File)
Sat, Aug 31, 11:18 AM
Subscribers

Details

Reviewers
des
emaste
Group Reviewers
Contributor Reviews (src)
Summary

It was removed with the recent update to upstream tzcode, but references in the header, symbol map and man pages remained.

Fixes: bc42155199 ("Bring our tzcode up to date.")
Reported by: ld.lld 16 being --no-undefined-version by default
Sponsored by: https://www.patreon.com/valpackett

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49575
Build 46465: arc lint + arc unit

Event Timeline

I honestly hadn't noticed that the tzcode update removed tzsetwall(3).

On the one hand, it's useless and nobody should be calling it.

On the other hand, we've had it for 30+ years and it's arguably part of our ABI.

On the gripping hand, this was merged to stable/13 eight days ago and nobody (including the package builders) noticed.

What do you think @emaste @imp? Should we reintroduce it as an alias for tzset(3), or implement something ourselves? I think the closest thing to the original spirit is “like tzset(3) but ignores the TZ environment variable, taking only /etc/localtime into account.”

@val_packett.cool can you file a PR instead and abandon this review?

Discussed briefly on IRC - suggestion was to make tzsetwall an alias for tzset, with linker magic to emit a deprecation warning