Differential D38355

netinet6: require network epoch for in6_pcbconnect()
ClosedPublic
Actions

Authored by glebius on Feb 2 2023, 8:14 PM.

Details

Reviewers

markj

Group Reviewers

transport

Commits

rG3d76be28ec60: netinet6: require network epoch for in6_pcbconnect()

Summary

This removes recursive epoch entry in the syncache case. Fixes
unprotected access to V_in6_ifaddrhead in in6_pcbladdr(), as
well as access to prison IP address lists. It also matches what
IPv4 in_pcbconnect() does.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Feb 2 2023, 8:14 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptFeb 2 2023, 8:14 PM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

glebius requested review of this revision.Feb 2 2023, 8:14 PM

Harbormaster completed remote builds in B49488: Diff 116358.Feb 2 2023, 8:14 PM

glebius added a parent revision: D38354: inpcb: merge two versions of in6_pcbconnect() into one.Feb 2 2023, 8:14 PM

glebius added a child revision: D38356: inpcb: use family specific sockaddr argument for connect functions.

markj accepted this revision.Feb 2 2023, 9:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2023, 7:34 PM

Closed by commit rG3d76be28ec60: netinet6: require network epoch for in6_pcbconnect() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG3d76be28ec60: netinet6: require network epoch for in6_pcbconnect().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_usrreq.c

3 lines

netinet6/

in6_pcb.c

10 lines

udp6_usrreq.c

4 lines

Diff 116439

View Options

sys/netinet/tcp_usrreq.c

View Options

sys/netinet6/in6_pcb.c

View Options

sys/netinet6/udp6_usrreq.c

netinet6: require network epoch for in6_pcbconnect()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 116439

sys/netinet/tcp_usrreq.c

sys/netinet6/in6_pcb.c

sys/netinet6/udp6_usrreq.c

netinet6: require network epoch for in6_pcbconnect()
ClosedPublic
Actions

Revision Contents
Changeset List