Page MenuHomeFreeBSD

ixgbe: Do not count l3/l4 checksum errors as input errors
ClosedPublic

Authored by gallatin on Feb 1 2023, 8:27 PM.
Tags
None
Referenced Files
F102143911: D38346.diff
Fri, Nov 8, 4:10 AM
Unknown Object (File)
Sun, Nov 3, 11:34 PM
Unknown Object (File)
Sat, Oct 12, 5:19 PM
Unknown Object (File)
Sat, Oct 12, 5:19 PM
Unknown Object (File)
Sat, Oct 12, 4:56 PM
Unknown Object (File)
Sep 20 2024, 4:47 PM
Unknown Object (File)
Sep 17 2024, 3:01 PM
Unknown Object (File)
Sep 16 2024, 8:41 PM
Subscribers

Details

Reviewers
erj
piotr.pietruszewski_intel.com
ae
glebius
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rG8de48df35c3b: ixgbe: Do not count L3/L4 checksum errors as input errors
Summary

NIC input errors have traditionally indicated problems at the link level (crc errors, runts, etc). Large companies tend to build monitoring infrastructure around such errors in order to monitor for bad network ports. When L3/L4 checksum errors are included in the category of input errors, it breaks such monitoring, as these errors can originate with hardware anywhere on the internet (not even under the control of the local administrator), and do not necessarily indicate faulty local network hardware.

In afb1aa4e6df245d38fd2ba683fa521d5dabe8392, L3/L4 checksum errors were included with input errors in ixgbe, and thus broke our (Netflix) monitoring infrastructure, due to elevated counts on some servers due to IP / TCP checksum errors caused by faulty equipment outside our control. I had patched around this locally, but due to a merge error, we recently lost that patch and just experienced the problem again. So I'd like to float the idea of removing L3/L4 checksum errors from input errors from ixgbe upstream.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable