Paths

Table of Contentst

dtrace_asm.S: properly enter/exit user access
ClosedPublic
Actions

Authored by mhorne on Jan 31 2023, 7:26 PM.

Details

Reviewers

markj
jrtc27
gnn

Group Reviewers

riscv

Commits

rG698af78e7809: dtrace_asm.S: properly enter/exit user access
rG0e563bde48b1: dtrace_asm.S: properly enter/exit user access

Summary

In order to read or write userspace memory without generating an access
fault, we must first enable the SUM bit in the sstatus CSR.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Jan 31 2023, 7:26 PM

Herald added a reviewer: gnn. · View Herald TranscriptJan 31 2023, 7:26 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.Jan 31 2023, 7:26 PM

Harbormaster completed remote builds in B49360: Diff 116114.Jan 31 2023, 7:26 PM

mhorne added a child revision: D38299: riscv: handle page faults in dtrace_trap().Jan 31 2023, 7:26 PM

mhorne mentioned this in D28054: dtrace: Fix RISC-V user stack unwinder.Jan 31 2023, 7:34 PM

markj added inline comments.Feb 1 2023, 3:24 PM

sys/cddl/dev/dtrace/riscv/dtrace_asm.S
151	What is `1b` referring to here?
152–154	There are multiple jumps to `2`, but they are not consistent about whether SUM is set.

Fix dtrace_copystr().

Harbormaster completed remote builds in B49415: Diff 116201.Feb 1 2023, 3:37 PM

mhorne marked 2 inline comments as done.Feb 1 2023, 3:38 PM

mhorne added inline comments.

sys/cddl/dev/dtrace/riscv/dtrace_asm.S
151	Yikes!

markj accepted this revision.Feb 6 2023, 6:22 PM

This revision is now accepted and ready to land.Feb 6 2023, 6:22 PM

Closed by commit rG0e563bde48b1: dtrace_asm.S: properly enter/exit user access (authored by mhorne). · Explain WhyFeb 6 2023, 7:28 PM

This revision was automatically updated to reflect the committed changes.

mhorne marked an inline comment as done.

mhorne added a commit: rG0e563bde48b1: dtrace_asm.S: properly enter/exit user access.

mhorne added a commit: rG698af78e7809: dtrace_asm.S: properly enter/exit user access.Feb 15 2023, 4:44 PM

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

dtrace/

riscv/

dtrace_asm.S

16 lines

Diff 116630

View Options

sys/cddl/dev/dtrace/riscv/dtrace_asm.S

dtrace_asm.S: properly enter/exit user accessClosedPublicActions